Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark images are not displayed #66

Closed
homersimpsons opened this issue Feb 9, 2024 · 0 comments · Fixed by #68
Closed

Benchmark images are not displayed #66

homersimpsons opened this issue Feb 9, 2024 · 0 comments · Fixed by #68

Comments

@homersimpsons
Copy link
Contributor

Navigate to https://rustpython.github.io/benchmarks.

Notice that the first images are not displayed:
image

This is because those are cbor files, at the bottom we can see the actual svg files.

This is certainly because we are not correclt loading them in https://github.com/RustPython/rustpython.github.io/blob/master/_layouts/benchmarks.html

In fact the data/main folder should not be loaded (directories with cbor files): https://github.com/RustPython/rustpython.github.io/tree/master/assets/criterion/data/main

But the root one should be (directories with svg files): https://github.com/RustPython/rustpython.github.io/tree/master/assets/criterion

I wanted to tackle this issue but came across #65

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant