Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rustpython notebook use case - post 1 of 2 #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustpython notebook use case - post 1 of 2 #30
Changes from 1 commit
6368e21
2186617
9c29640
86109a5
5f9fc00
47da4b5
e637a99
cf38672
afa7e50
834413e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this, you might want to use something more general than google doc, like 'pdf file' or 'document' or something and maybe use that same terminology for the whole paragraph. I think using google docs as an example might confuse things, since google docs require a central server but we don't.
Also, what specifically do you mean by "opening old documents would require you to rollback your changes"? Is that like using git for notebook files? Cause I think if you're making new documents by overwriting the same files, you'd be using git wrong :P. I don't really use jupyter, so I don't know how version control is for that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an interesting point. I think Google docs and RustPython notebook work same way for the notebook users. Free and 24/7 opening central servers are not very far from browser-hosted platform for users unless network is not available.
But if this article starts with this:
It will be big difference for the contributors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this section could use some consistency. I do use a google doc in the sub-title, then switch to using a PDF example in the middle of the paragraph to illustrate a point about local configuration...
I meant to illustrate the example of a worry free and easy to share analogy, so I used google doc. Probably a GitHub repo used to host a static site is technically more accurate. I am not sure if it will resonate as much. I could find a way to mention both.
For rolling back changes, i meant to use an imaginary example case that highlights the redundancy or inefficiency of repeated work when you have to configure a version of a reader/python and fonts/libraries. I think I will take out the part about old document or write it more clearly.