Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the explainer an HTML table #31

Merged
merged 3 commits into from
Dec 10, 2020
Merged

Make the explainer an HTML table #31

merged 3 commits into from
Dec 10, 2020

Conversation

coolreader18
Copy link
Member

I also did some optimizations for tablets so that the content isn't 25% width like it would be on desktops; it was pretty scrunched. Also also, I changed the explainer text and added some text relating to our progress the goals that we had, that we can eventually add to those boxes.

@coolreader18
Copy link
Member Author

The HTML table looks better with the dark mode extension I have:
image

@@ -3,7 +3,11 @@
# To modify the layout, see https://jekyllrb.com/docs/themes/#overriding-theme-defaults

layout: home
explainer: "CPython is the common implementation of Python. We love C, but we love Rust a little more 😉... that's why we're working on a RustPython, a Python implementation written in Rust. We are doing it for fun, to learn about writing interpreters, and to have a useful, usable and embeddable implementation of Python in Rust."
explainer:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for the re-write.

Full Python-3 environment entirely in Rust (not CPython bindings), with
a clean implementation and no compatiblity hacks.
# TODO: integrate this into the "goals" boxes
progress:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the progress boxes or text. Is the progress box supposed to show somewhere on the homepage?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking something like split the goals boxes into 2 vertically with the goal on top and progress on bottom:

image

(very rough sketch, of course)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah that works :D

If you want, you don't have to stick to the background I used. You can probably use borders or some form of highlight.

@mireille-raad
Copy link
Member

I think you can merge.

My one comment is that it would be nice to see the "progress" boxes show up on the homepage.

We can add those later maybe after we figure out some numbers for the progress.

@coolreader18 coolreader18 merged commit 68362cf into master Dec 10, 2020
@coolreader18 coolreader18 deleted the explainer-table branch December 10, 2020 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants