Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added build steps for windows #7

Closed
wants to merge 1 commit into from
Closed

Conversation

Joetib
Copy link

@Joetib Joetib commented Apr 4, 2020

Added Detailed steps to build RustPython on a windows environment.

Comment on lines +18 to +35
- Next we need to install openssl since RustPython depends on it. However the build process for openssl is not very straight forward. We employ [Vcpkg](https://github.com/Microsoft/vcpkg) to help us. [Clone Vcpkg](https://github.com/Microsoft/vcpkg "Vcpkg github repository") into a folder of your choosing. I will use ```C:\vcpkg\``` in this example. Following vcpkg's installation guide, in the cloned directory

From your Powershell run the scripts.
```Powershell
PS C:\vcpkg> .\bootstrap-vcpkg.bat
PS C:\vcpkg> .\vcpkg integrate install
```

Finally we install openssl by running
```Powershell
PS C:\vcpkg> .\vcpkg install openssl:x64-windows
```
Get some coffee for this one.
After the installation is done, there will be a created path
```
C:\vcpkg\installed\x64-windows\
```
Edit your User environment Variables or System Variables, whichever you prefer and set `OPENSSL_DIR` to this path
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this isn't necessary anymore since RustPython/RustPython#1841, as far as I can tell all that's necessary is a perl installation like Strawberry Perl in order to build openssl.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops didn't catch that.
I will work on that.

Comment on lines +55 to +59
copy the `.dll` files `libcrypto-1_1-x64.dll` and `libssl-1_1-x64.dll` from
```
C:\vcpkg\installed\x64-windows\bin
```
or the `bin` folder of wherever you installed openssl to into the ```targets/release``` directory.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this shouldn't be necessary either, as openssl is statically linked.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Until I copied it, I didn't get the built exe running. At least that was for me.

```
or the `bin` folder of wherever you installed openssl to into the ```targets/release``` directory.

## Now run *`ruspython.exe`* and enjoy it's beauty.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

Suggested change
## Now run *`ruspython.exe`* and enjoy it's beauty.
## Now run *`rustpython.exe`* and enjoy it's beauty.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, Fixing that right up.

@coolreader18
Copy link
Member

Sorry for taking a bit to get to this, I think the installation steps have been simplified since you wrote this, so hopefully it'll be easier to install on windows.

@Joetib
Copy link
Author

Joetib commented Apr 13, 2020

@coolreader18
I get the feeling I need to ask whether the post is still needed.
Is it?

@Joetib
Copy link
Author

Joetib commented May 11, 2020

After this long I think it's not needed anymore. I'll close this by the end of the day if I do not hear otherwise.

@windelbouwman
Copy link

windelbouwman commented May 11, 2020

Hi, thanks for contributing! Sorry for the delay. We recently discussed the windows situation. We decided that the openssl module will be disabled on windows by default, so people get a better out of box experience on windows (allthough it is without the openssl module).

Still I think this post is relevant to describe how to build with all features enabled on windows. Maybe the title should be changed into windows build tips and tricks

@Joetib
Copy link
Author

Joetib commented May 27, 2020

Okay @windelbouwman I'll get to work with it. Sorry I did not get to this earlier but I haven't checked my mail lately and I was loosing hope of this being accepted. I'm off to work.

@mireille-raad
Copy link
Member

I am closing this PR because it seems obsolete. @Joetib I hope you find something new to contribute to RustPython!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants