Skip to content

Objects in lists with a primitive property are tagged with ADDED if they are removed #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
hheg opened this issue Jun 14, 2016 · 1 comment
Open

Objects in lists with a primitive property are tagged with ADDED if they are removed #165

hheg opened this issue Jun 14, 2016 · 1 comment

Comments

@hheg
Copy link

hheg commented Jun 14, 2016

Objects in lists with a primitive property are tagged with State.ADDED if they are removed. As seen in the PR #164 the test case.

I'm sorry if this didn't end up as a proper issue because I'm rather new at this, but I really like this library and use it extensively :) I haven't had the time to check if I can fix it myself, but I probably will.
@SQiShER
Copy link
Owner

SQiShER commented Jun 15, 2016

Don't worry, the PR is great! Having a test to reproduce the issue always makes it so much easier. I can't promise how soon I'll be able to work on this, so feel free to give it a shot. I'd be happy to assist you with any questions that arise. 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SQiShER @hheg