Skip to content

Commit 3ef1c25

Browse files
committed
[js] Chrome capabilities test passes now in RBE
1 parent 94e0560 commit 3ef1c25

File tree

3 files changed

+15
-15
lines changed

3 files changed

+15
-15
lines changed

.skipped-tests

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222
-//javascript/selenium-webdriver:test-builder-test.js-chrome
2323
-//javascript/selenium-webdriver:test-chrome-devtools-test.js-chrome
2424
-//javascript/selenium-webdriver:test-firefox-options-test.js-firefox
25-
-//javascript/selenium-webdriver:test-lib-capabilities-test.js-chrome
2625
-//rb/spec/integration/selenium/webdriver/chrome:service-chrome
2726
-//rb/spec/integration/selenium/webdriver/chrome:service-chrome-bidi
2827
-//rb/spec/integration/selenium/webdriver/chrome:service-chrome-remote

javascript/selenium-webdriver/test/firefox/options_test.js

Lines changed: 13 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ suite(
6363

6464
describe('setProfile', function () {
6565
it('use profile with custom prefs', async function () {
66-
let options = new firefox.Options()
66+
let options = env.builder().getFirefoxOptions() || new firefox.Options()
6767
options.setProfile(profileWithUserPrefs)
6868

6969
driver = env.builder().setFirefoxOptions(options).build()
@@ -73,7 +73,7 @@ suite(
7373
})
7474

7575
it('use profile with extension', async function () {
76-
let options = new firefox.Options()
76+
let options = env.builder().getFirefoxOptions() || new firefox.Options()
7777
options.setProfile(profileWithWebExtension)
7878

7979
driver = env.builder().setFirefoxOptions(options).build()
@@ -116,7 +116,7 @@ suite(
116116
})
117117

118118
it('can start Firefox with custom preferences', async function () {
119-
let options = new firefox.Options()
119+
let options = env.builder().getFirefoxOptions() || new firefox.Options()
120120
options.setPreference('general.useragent.override', 'foo;bar')
121121

122122
driver = env.builder().setFirefoxOptions(options).build()
@@ -126,9 +126,9 @@ suite(
126126
})
127127

128128
it('can add extra prefs on top of an existing profile', async function () {
129-
let options = new firefox.Options()
130-
.setPreference('general.useragent.override', 'foo;bar')
131-
.setProfile(profileWithWebExtension)
129+
let options = env.builder().getFirefoxOptions() || new firefox.Options()
130+
options.setPreference('general.useragent.override', 'foo;bar')
131+
options.setProfile(profileWithWebExtension)
132132

133133
driver = env.builder().setFirefoxOptions(options).build()
134134

@@ -140,7 +140,7 @@ suite(
140140

141141
describe('addExtensions', function () {
142142
it('can add extension to brand new profile', async function () {
143-
let options = new firefox.Options()
143+
let options = env.builder().getFirefoxOptions() || new firefox.Options()
144144
options.addExtensions(EXT_XPI)
145145

146146
driver = env.builder().setFirefoxOptions(options).build()
@@ -150,7 +150,8 @@ suite(
150150
})
151151

152152
it('can add extension to custom profile', async function () {
153-
let options = new firefox.Options().addExtensions(EXT_XPI).setProfile(profileWithUserPrefs)
153+
let options = env.builder().getFirefoxOptions() || new firefox.Options()
154+
options.addExtensions(EXT_XPI).setProfile(profileWithUserPrefs)
154155

155156
driver = env.builder().setFirefoxOptions(options).build()
156157

@@ -160,9 +161,9 @@ suite(
160161
})
161162

162163
it('can addExtensions and setPreference', async function () {
163-
let options = new firefox.Options()
164-
.addExtensions(EXT_XPI)
165-
.setPreference('general.useragent.override', 'foo;bar')
164+
let options = env.builder().getFirefoxOptions() || new firefox.Options()
165+
options.addExtensions(EXT_XPI)
166+
options.setPreference('general.useragent.override', 'foo;bar')
166167

167168
driver = env.builder().setFirefoxOptions(options).build()
168169

@@ -172,7 +173,7 @@ suite(
172173
})
173174

174175
it('can load .zip webextensions', async function () {
175-
let options = new firefox.Options()
176+
let options = env.builder().getFirefoxOptions() || new firefox.Options()
176177
options.addExtensions(EXT_XPI)
177178

178179
driver = env.builder().setFirefoxOptions(options).build()

javascript/selenium-webdriver/test/lib/capabilities_test.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@ test.suite(function (env) {
142142
.it(
143143
'should fail to upload files to a non interactable input when StrictFileInteractability is on',
144144
async function () {
145-
const options = new chrome.Options()
145+
const options = env.builder().getChromeOptions() || new chrome.Options()
146146
options.setStrictFileInteractability(true)
147147
const driver = env.builder().setChromeOptions(options).build()
148148

@@ -181,7 +181,7 @@ test.suite(function (env) {
181181
return fp
182182
})
183183

184-
const options = new chrome.Options()
184+
const options = env.builder().getChromeOptions() || new chrome.Options()
185185
options.setStrictFileInteractability(false)
186186
const driver = env.builder().setChromeOptions(options).build()
187187

0 commit comments

Comments
 (0)