Skip to content

Commit d1f9874

Browse files
Delta456diemol
andauthored
[py] remove xfail attr for firefox and safari for cookie tests (#14794)
[py] remove xfail attr for firefox and safari Co-authored-by: Diego Molina <diemol@users.noreply.github.com>
1 parent 1545600 commit d1f9874

File tree

1 file changed

+0
-7
lines changed

1 file changed

+0
-7
lines changed

py/test/selenium/webdriver/common/cookie_tests.py

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -80,35 +80,28 @@ def test_add_cookie(cookie, driver):
8080
assert cookie["name"] in returned
8181

8282

83-
@pytest.mark.xfail_firefox(reason="sameSite cookie attribute not implemented")
8483
@pytest.mark.xfail_remote(reason="sameSite cookie attribute not implemented")
85-
@pytest.mark.xfail_safari
8684
def test_add_cookie_same_site_strict(same_site_cookie_strict, driver):
8785
driver.add_cookie(same_site_cookie_strict)
8886
returned = driver.get_cookie("foo")
8987
assert "sameSite" in returned and returned["sameSite"] == "Strict"
9088

9189

92-
@pytest.mark.xfail_firefox(reason="sameSite cookie attribute not implemented")
9390
@pytest.mark.xfail_remote(reason="sameSite cookie attribute not implemented")
94-
@pytest.mark.xfail_safari
9591
def test_add_cookie_same_site_lax(same_site_cookie_lax, driver):
9692
driver.add_cookie(same_site_cookie_lax)
9793
returned = driver.get_cookie("foo")
9894
assert "sameSite" in returned and returned["sameSite"] == "Lax"
9995

10096

101-
@pytest.mark.xfail_firefox(reason="sameSite cookie attribute not implemented")
10297
@pytest.mark.xfail_remote(reason="sameSite cookie attribute not implemented")
103-
@pytest.mark.xfail_safari
10498
def test_add_cookie_same_site_none(same_site_cookie_none, driver):
10599
driver.add_cookie(same_site_cookie_none)
106100
# Note that insecure sites (http:) can't set cookies with the Secure directive.
107101
# driver.get_cookie would return None
108102

109103

110104
@pytest.mark.xfail_ie
111-
@pytest.mark.xfail_safari
112105
def test_adding_acookie_that_expired_in_the_past(cookie, driver):
113106
expired = cookie.copy()
114107
expired["expiry"] = calendar.timegm(time.gmtime()) - 1

0 commit comments

Comments
 (0)