Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Popup] Fix a white space property in tooltip #6249

Open
wants to merge 2 commits into
base: next
Choose a base branch
from

Conversation

kikunantoka
Copy link

Closed Issues

#4187

Description

I found tooltip is not fully visible when tooltip has many contents. This is caused by selecting "nowrap" property as white-space in tooltip after element. So, I changed white-space property into "normal" from "nowrap".

Testcase

Before

before

https://jsfiddle.net/ca0rovs3/271/

After

after

https://jsfiddle.net/ca0rovs3/272/

@y0hami
Copy link
Member

y0hami commented Mar 7, 2018

Some people might want tooltips to be on a single line. I think maybe there should be an option to keep this behaviour like data-single-line

@kikunantoka
Copy link
Author

I agree your opinion. I think your idea is really good. Should I include a data-single-line option in this PR?

@y0hami
Copy link
Member

y0hami commented Mar 7, 2018

Yes, go for it!

Also if you create a PR to add it to the docs that would be a massive help!

@kikunantoka
Copy link
Author

Ok. I try to add a data-single-line option later.

I'll send another PR for documentation if I try to add it to the doc.

@kikunantoka
Copy link
Author

I added a data-single-line option.

@jlukic
Copy link
Member

jlukic commented Mar 14, 2018

This might be more complicated than it seems. nowrap solves inadvertent text wrapping caused by certain css conditions for the activating element.

@kikunantoka
Copy link
Author

Thanks for your comment. I understand that.
If my commits might cause inconvenience, please close this PR.

@jlukic
Copy link
Member

jlukic commented Mar 18, 2018

I think we can just add a wrapping variation, and leave default behavior

@jlukic jlukic added this to the 2.3.3 milestone Mar 18, 2018
@allenwu1973
Copy link

Not sure is really related to this, but I find setting white-space: pre and using line breaks is quite helpful for long tooltips.

@lubber-de

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants