generated from VectorInstitute/aieng-template
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update metrics command #53
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he server URL is not ready
for more information, see https://pre-commit.ci
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #53 +/- ##
===========================================
+ Coverage 74.83% 79.50% +4.67%
===========================================
Files 4 4
Lines 445 522 +77
===========================================
+ Hits 333 415 +82
+ Misses 112 107 -5
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Feature/Fix
Short Description
When the server is not yet ready and if the command is used:
If server is available, then it looks like:
Note that the prompt and throughput rates are calculated by us and not provided by the metrics endpoint.
Computed metrics:
Note that the throughput is calculated over every second when the fetch_metrics() method is called while refreshing the TUI. It then displays the last computed value of throughout instead of reverting to 0.0 even when no requests are being served. If new requests get served, then the throughput is re-computed and updated.
Tests Added
...