chore: docs starter #8478
chore: docs starter #8478
Conversation
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
There was a problem hiding this comment.
Thanks for working on this! The real icons definitely make the design look a lot better ❤️
I think there are probably a few more common components we can share in some places. Left a few comments but there are probably others.
A few places are also still depending directly on the CSS rather than the component.
Let's also make sure we're exporting styled components for all the pieces. The stories should probably not be importing directly from react-aria-components and relying on the CSS. They should import styled components from src. I think that would match more closely with how we'd recommend using RAC.
starters/docs/src/Toolbar.css
Outdated
| } | ||
| } | ||
|
|
||
| .react-aria-Separator { |
There was a problem hiding this comment.
wonder if this should be specific to toolbar or pulled out into a general Separator component?
There was a problem hiding this comment.
I think i'd opt to leave it as is for the moment, we didn't reuse it in S2 as much either and none of the other stories/components are currently using this
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
| @@ -0,0 +1,38 @@ | |||
| 'use client'; | |||
| import { | |||
| Button, | |||
There was a problem hiding this comment.
I guess this is still technically depending on the Button.css being loaded on the page? I'm not sure NumberField.css has complete styles for it?
| export function Popover({ children, hideArrow, noPadding, ...props }: PopoverProps) { | ||
| return ( | ||
| ( | ||
| <AriaPopover {...props} className={clsx("react-aria-Popover react-aria-Dialog", props.className, { |
There was a problem hiding this comment.
Why does Popover have Dialog's styles applied to it? Noticed that there was extra padding in ComboBox (which I guess needs the noPadding prop to undo it?), and react-aria-Dialog also sets overflow: auto which breaks the overlay arrow.
|
Build successful! 🎉 |
Closes
Have docs starter be a source of truth instead of writing lots of strange code to extract it from the docs.
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: