-
Notifications
You must be signed in to change notification settings - Fork 1.3k
chore: docs starter #8478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore: docs starter #8478
Conversation
Build successful! 🎉 |
Build successful! 🎉 |
Build successful! 🎉 |
Build successful! 🎉 |
Build successful! 🎉 |
Build successful! 🎉 |
Build successful! 🎉 |
Build successful! 🎉 |
Build successful! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this! The real icons definitely make the design look a lot better ❤️
I think there are probably a few more common components we can share in some places. Left a few comments but there are probably others.
A few places are also still depending directly on the CSS rather than the component.
Let's also make sure we're exporting styled components for all the pieces. The stories should probably not be importing directly from react-aria-components
and relying on the CSS. They should import styled components from src. I think that would match more closely with how we'd recommend using RAC.
starters/docs/src/Toolbar.css
Outdated
} | ||
} | ||
|
||
.react-aria-Separator { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wonder if this should be specific to toolbar or pulled out into a general Separator component?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think i'd opt to leave it as is for the moment, we didn't reuse it in S2 as much either and none of the other stories/components are currently using this
Build successful! 🎉 |
Build successful! 🎉 |
Build successful! 🎉 |
Build successful! 🎉 |
Closes
Have docs starter be a source of truth instead of writing lots of strange code to extract it from the docs.
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: