Skip to content

chore: docs starter #8478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 23 commits into
base: main
Choose a base branch
from
Open

chore: docs starter #8478

wants to merge 23 commits into from

Conversation

snowystinger
Copy link
Member

Closes
Have docs starter be a source of truth instead of writing lots of strange code to extract it from the docs.

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@snowystinger snowystinger changed the title Chore docs starter chore: docs starter Jul 2, 2025
@rspbot
Copy link

rspbot commented Jul 2, 2025

@rspbot
Copy link

rspbot commented Jul 2, 2025

@rspbot
Copy link

rspbot commented Jul 3, 2025

@rspbot
Copy link

rspbot commented Jul 3, 2025

@rspbot
Copy link

rspbot commented Jul 3, 2025

@rspbot
Copy link

rspbot commented Jul 3, 2025

@rspbot
Copy link

rspbot commented Jul 3, 2025

@rspbot
Copy link

rspbot commented Jul 3, 2025

@rspbot
Copy link

rspbot commented Jul 7, 2025

Copy link
Member

@devongovett devongovett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! The real icons definitely make the design look a lot better ❤️

I think there are probably a few more common components we can share in some places. Left a few comments but there are probably others.

A few places are also still depending directly on the CSS rather than the component.

Let's also make sure we're exporting styled components for all the pieces. The stories should probably not be importing directly from react-aria-components and relying on the CSS. They should import styled components from src. I think that would match more closely with how we'd recommend using RAC.

}
}

.react-aria-Separator {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wonder if this should be specific to toolbar or pulled out into a general Separator component?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think i'd opt to leave it as is for the moment, we didn't reuse it in S2 as much either and none of the other stories/components are currently using this

@rspbot
Copy link

rspbot commented Jul 9, 2025

@rspbot
Copy link

rspbot commented Jul 9, 2025

@rspbot
Copy link

rspbot commented Jul 9, 2025

@rspbot
Copy link

rspbot commented Jul 10, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants