[Live Update] Fix: Correct color range for Color.valueOf

[chigichan24]

Description

This pull request addresses a bug in SnackbarNotificationManager where incorrect arguments were passed to the Color.valueOf(r, g, b, a) method.

The Color.valueOf method expects the red, green, and blue float components to be in the range of 0.0 to 1.0. The previous implementation was incorrectly passing values in the 0-255 range, which caused the colors for the notification's ProgressStyle to be rendered incorrectly (likely clamped to the maximum value).

This change normalizes the RGB values by dividing them by 255f, ensuring the pointColor and segmentColor are created with the intended shades.

Changes

Modified the pointColor and segmentColor value assignments in buildBaseProgressStyle to use normalized RGB values.

Screenshot

Before	After

How to test

1. Run the live-updates sample.
2. Trigger a notification that displays the ProgressStyle.
3. Verify that the colors of the progress points and segments now render correctly as per the intended RGB values.

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[gemini-code-assist]

Summary of Changes

Hello @chigichan24, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a critical color rendering issue within the notification system by correcting the input range for color component values. The change ensures that progress bar colors are displayed accurately by normalizing RGB values to the expected 0.0-1.0 float range, thereby improving the visual fidelity of notifications.

Highlights

• Bug Fix: Color Rendering: Addressed a bug in SnackbarNotificationManager where Color.valueOf was incorrectly called with RGB values in the 0-255 integer range, instead of the expected 0.0-1.0 float range. This caused incorrect color rendering for notification ProgressStyle elements.
• Color Value Normalization: Implemented normalization for the pointColor and segmentColor assignments within the buildBaseProgressStyle method. RGB components are now explicitly divided by 255f to convert them to the correct 0.0-1.0 float range required by Color.valueOf, ensuring accurate color representation.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request fixes an issue where incorrect RGB values were being passed to the Color.valueOf method, causing incorrect color rendering in the ProgressStyle notification. The fix normalizes the RGB values by dividing them by 255f. I've suggested adding comments to clarify the normalization process for better code maintainability.