Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs-bug(CdkTree): Most examples are broken #30600

Closed
ManelBH opened this issue Mar 7, 2025 · 1 comment · Fixed by #30601
Closed

docs-bug(CdkTree): Most examples are broken #30600

ManelBH opened this issue Mar 7, 2025 · 1 comment · Fixed by #30601
Assignees
@crisbeto
Labels
docs This issue is related to documentation P2 The issue is important to a large percentage of users, with a workaround

Comments

@ManelBH
Copy link

ManelBH commented Mar 7, 2025 •
edited
Loading

Documentation Feedback

The following examples in the cdk tree page are broken or incomplete and won't compile in Stackblitz:

cdk-tree-nested-level-accessor-example
cdk-tree-nested-children-accessor-example
cdk-tree-flat-level-accessor-example
cdk-tree-flat-children-accessor-example
cdk-tree-complex-example

Affected documentation page

https://material.angular.io/cdk/tree/examples
@ManelBH ManelBH added docs This issue is related to documentation needs triage This issue needs to be triaged by the team labels Mar 7, 2025
crisbeto added a commit to crisbeto/material2 that referenced this issue Mar 7, 2025
@crisbeto
docs(cdk/tree): examples not working when forked to Stackblitz
7817d36 
The tree examples were breaking down when forked to Stackblitz, because of a couple of reasons:
1. They had their sample data in a separate file which the build process wasn't picking up.
2. They had compilation errors only with rxjs 7+ which we didn't notice, because our local setup is on rxjs 6.

I also went through all the examples and moved the sample data further down so it doesn't distract from the actual code.

Fixes angular#30600.
@crisbeto crisbeto self-assigned this Mar 7, 2025
@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround and removed needs triage This issue needs to be triaged by the team labels Mar 7, 2025
@crisbeto crisbeto mentioned this issue Mar 7, 2025
Merged
crisbeto added a commit to crisbeto/material2 that referenced this issue Mar 7, 2025
@crisbeto
docs(cdk/tree): examples not working when forked to Stackblitz
23bc6bd 
The tree examples were breaking down when forked to Stackblitz, because of a couple of reasons:
1. They had their sample data in a separate file which the build process wasn't picking up.
2. They had compilation errors only with rxjs 7+ which we didn't notice, because our local setup is on rxjs 6.

I also went through all the examples and moved the sample data further down so it doesn't distract from the actual code.

Fixes angular#30600.
@pedroestabruxelles
Copy link

It was reported by me here: #30159

crisbeto added a commit that referenced this issue Mar 7, 2025
@crisbeto
docs(cdk/tree): examples not working when forked to Stackblitz (#30601)
5a98cc6 
The tree examples were breaking down when forked to Stackblitz, because of a couple of reasons:
1. They had their sample data in a separate file which the build process wasn't picking up.
2. They had compilation errors only with rxjs 7+ which we didn't notice, because our local setup is on rxjs 6.

I also went through all the examples and moved the sample data further down so it doesn't distract from the actual code.

Fixes #30600.
crisbeto added a commit that referenced this issue Mar 7, 2025
@crisbeto
docs(cdk/tree): examples not working when forked to Stackblitz (#30601)
8a4831a 
The tree examples were breaking down when forked to Stackblitz, because of a couple of reasons:
1. They had their sample data in a separate file which the build process wasn't picking up.
2. They had compilation errors only with rxjs 7+ which we didn't notice, because our local setup is on rxjs 6.

I also went through all the examples and moved the sample data further down so it doesn't distract from the actual code.

Fixes #30600.

(cherry picked from commit 5a98cc6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crisbeto crisbeto

Labels
docs This issue is related to documentation P2 The issue is important to a large percentage of users, with a workaround
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs(cdk/tree): examples not working when forked to Stackblitz crisbeto/material2
3 participants
@crisbeto @pedroestabruxelles @ManelBH