build: update to Angular v20 and Node v20 #30595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angular-robot
bot
added
the
area: build & ci
Updates the repo to Angular 20 and the CI to Node 20 since the CLI dropped support for Node 18 which we were using.
crisbeto
changed the title
crisbeto
requested review from
mmalerba,
andrewseguin and
devversion
and removed request for
a team
crisbeto
commented
Mar 6, 2025
| - await fs.promises.rm(testTmpDir, {force: true, recursive: true, maxRetries: 3}); | ||
| + | ||
| + try { | ||
| + fs.rmSync(testTmpDir, {force: true, recursive: true, maxRetries: 3}); |
There was a problem hiding this comment.
Note: for some reason await fs.promises.rm wasn't being caught by the try/catch. Might be some weirdness with it being monkey-patched. That's why I replaced it with the sync version.
devversion
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the repo to Angular 20 and the CI to Node 20 since the CLI dropped support for Node 18 which we were using.