fix(material/select): use flexible overlay dimensions #30628
Merged
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewseguin
added
target: patch
andrewseguin
requested review from
crisbeto and
mmalerba
and removed request for
a team
andrewseguin
force-pushed
the
select-height
branch
2 times, most recently
from
5653865 to
566b98a
Compare
|
Deployed dev-app for 55a6263 to: https://ng-dev-previews-comp--pr-angular-components-30628-dev-qtqevu3l.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
crisbeto
approved these changes
Mar 13, 2025
andrewseguin
force-pushed
the
select-height
branch
from
d6a42c4 to
55a6263
Compare
|
The changes were merged into the following branches: main, 19.2.x |
andrewseguin
added a commit
that referenced
this pull request
Mar 17, 2025
(cherry picked from commit d5ba63d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the browser window is small, the select's listbox panel does not shrink in size, which causes options to become unreachable.
With flexible positioning, the overlay is constrained in height causing the panel to shrink as well, rendering all available options with scrolling
Example: Panel displayed underneath the select.
Observe that the Milk option was not fully visible when the panel is scrolled all the way down
Before:
After:
Example: Panel displayed above the select.
Observe the None option was not at all visible when scrolled up
Before:
After: