fix(material/timepicker): TimepickerInput component in shadow DOM #30642
+22
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calebkish
requested review from
mmalerba and
andrewseguin
and removed request for
a team
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
calebkish
force-pushed
the
mat-timepicker-input-focus-shadow-dom-fix
branch
from
4070e9b to
b06aebd
Compare
crisbeto
reviewed
Mar 18, 2025
crisbeto
approved these changes
Mar 19, 2025
crisbeto
added
action: merge
crisbeto
requested changes
Mar 19, 2025
Fixes an issue where the value of the input element referenced by a TimepickerInput component inside a shadow DOM was getting formatted too often due to `TimepickerInput._hasFocus()` assuming the component wasn't in the shadow DOM. Fixes angular#30641
calebkish
force-pushed
the
mat-timepicker-input-focus-shadow-dom-fix
branch
from
abc1347 to
442866e
Compare
crisbeto
approved these changes
Mar 19, 2025
crisbeto
pushed a commit
that referenced
this pull request
Mar 19, 2025
…0642) Fixes an issue where the value of the input element referenced by a TimepickerInput component inside a shadow DOM was getting formatted too often due to `TimepickerInput._hasFocus()` assuming the component wasn't in the shadow DOM. Fixes #30641 Co-authored-by: Caleb Kish <j69674031@gmail.com> (cherry picked from commit ee44255)
|
The changes were merged into the following branches: main, 19.2.x |
mistrykaran91
pushed a commit
to mistrykaran91/components
that referenced
this pull request
Mar 20, 2025
…gular#30642) Fixes an issue where the value of the input element referenced by a TimepickerInput component inside a shadow DOM was getting formatted too often due to `TimepickerInput._hasFocus()` assuming the component wasn't in the shadow DOM. Fixes angular#30641 Co-authored-by: Caleb Kish <j69674031@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where the value of the input element referenced by a TimepickerInput component inside a shadow DOM was getting formatted too often due to
TimepickerInput._hasFocus()assuming the component wasn't in the shadow DOM.Fixes #30641