Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename mdc- prefixed tokens/variables to mat- #30677

Merged
merged 3 commits into from
Mar 27, 2025

Conversation

andrewseguin
Copy link
Contributor

@andrewseguin andrewseguin commented Mar 20, 2025

BREAKING CHANGE:

  • Theming CSS variables prefixed with --mdc- are now prefixed with --mat-. Stylesheets that directly define these variables should be automatically renamed with the update schematic. To avoid future breaking changes as variables may be renamed or removed, use the overrides API which will provide a safer abstraction along with token-name checks.

@andrewseguin andrewseguin added the target: major This PR is targeted for the next major release label Mar 20, 2025
@andrewseguin andrewseguin requested a review from a team as a code owner March 20, 2025 23:00
@andrewseguin andrewseguin requested review from crisbeto, wagnermaciel and mmalerba and removed request for a team March 20, 2025 23:00
Copy link
Contributor

@wagnermaciel wagnermaciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this going to ship with a schematic?

Edit: Nevermind, just read the description. LGTM!

@andrewseguin
Copy link
Contributor Author

Yeah just a simple find-and-replace for --mdc with --mat

Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This didn't result in any name collisions? I'm pleasantly surprised

@andrewseguin andrewseguin added the action: merge The PR is ready for merge by the caretaker label Mar 27, 2025
@andrewseguin andrewseguin merged commit ad6a21e into angular:main Mar 27, 2025
23 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants