fix(cdk/overlay): ensure re-exported transitive Dir directive can be imported
#30679
+57
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
added
target: patch
1 task
crisbeto
approved these changes
Mar 21, 2025
…e imported This is a follow-up to cb3b0a8 which did miss this transitive re-export of the `Dir` directive. The compiler will try the last module import, so even if e.g. `./scrolling` re-exported `Dir` as of the initial commit, the compiler would try importing via `@angular/cdk/overlay`. This commit fixes this remaining instance, and updates the new testing infrastructure to import/test every module in isolation. The tests didn't notice that issue because the compiler discovered the `Dir` directive/"Reference" already via another import that "worked". Fixes angular#30663.
devversion
force-pushed
the
follow-up-fix-dir
branch
from
d62a684 to
550975d
Compare
devversion
added
action: merge
|
The changes were merged into the following branches: main, 19.2.x |
devversion
added a commit
that referenced
this pull request
Mar 21, 2025
…e imported (#30679) This is a follow-up to cb3b0a8 which did miss this transitive re-export of the `Dir` directive. The compiler will try the last module import, so even if e.g. `./scrolling` re-exported `Dir` as of the initial commit, the compiler would try importing via `@angular/cdk/overlay`. This commit fixes this remaining instance, and updates the new testing infrastructure to import/test every module in isolation. The tests didn't notice that issue because the compiler discovered the `Dir` directive/"Reference" already via another import that "worked". Fixes #30663. (cherry picked from commit 1e5082d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to cb3b0a8 which did miss this transitive re-export of the
Dirdirective. The compiler will try the last module import, so even if e.g../scrollingre-exportedDiras of the initial commit, the compiler would try importing via@angular/cdk/overlay.This commit fixes this remaining instance, and updates the new testing infrastructure to import/test every module in isolation. The tests didn't notice that issue because the compiler discovered the
Dirdirective/"Reference" already via another import that "worked".Fixes #30663.