HBASE-29399 Update hadoop-metrics2-hbase.properties template #7108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the hadoop-metrics2-hbase.properties template in support of HBASE-29399 by enhancing the configuration comments and renaming sink definitions for clarity and consistency.
- Updated comment delimiters to "##" for better clarity.
- Added configuration hints for regex-based metric filtering.
- Renamed sink configuration keys to follow updated naming conventions.
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
junegunn
commented
Jun 18, 2025
Comment on lines
+17
to
+20
| ## syntax: [prefix].[source|sink].[instance].[options] | ||
| ## See javadoc of package-info.java for org.apache.hadoop.metrics2 for details | ||
|
|
||
| *.sink.file*.class=org.apache.hadoop.metrics2.sink.FileSink | ||
| # default sampling period | ||
| ## Default sampling period, in seconds |
There was a problem hiding this comment.
Used double # to distinguish actual comments from commented-out configuration lines.
junegunn
commented
Jun 18, 2025
| ## You can use regular expressions to exclude metrics you don't need. | ||
|
|
||
| # hbase.source.metric.filter.class=org.apache.hadoop.metrics2.filter.RegexFilter | ||
| # hbase.source.metric.filter.exclude=.*_((25|75|90|95|98)th_percentile|min|mean) |
There was a problem hiding this comment.
We internally use the median value (50th percentile), so we decided to exclude mean values. But anyway, this is just an example.
There was a problem hiding this comment.
With this configuration, the scraping time of jmx_exporter was significantly reduced on some of our regionservers. I believe others could also benefit from applying a similar configuration.
Apache9
approved these changes
Jun 29, 2025
junegunn
added a commit
that referenced
this pull request
Jun 30, 2025
Signed-off-by: Duo Zhang <zhangduo@apache.org>
junegunn
added a commit
that referenced
this pull request
Jun 30, 2025
Signed-off-by: Duo Zhang <zhangduo@apache.org>
junegunn
added a commit
that referenced
this pull request
Jun 30, 2025
Signed-off-by: Duo Zhang <zhangduo@apache.org>
junegunn
added a commit
that referenced
this pull request
Jun 30, 2025
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/HBASE-29399