HIVE-29051: TestTezTPCDS30TBPerfCliDriver leaks Postgres container causing intermittent failures elsewhere #5908
+4
−47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…using intermittent failures elsewhere 1. Move metastore/container destroy logic in buildClassRule of CliAdapter. All database/container lifecyle handling must be in the same place to avoid leaks and inconsistent behavior. 2. Rename QTestMetastoreHandler#afterTest to QTestMetastoreHandler#truncateDatabase to better reflect what is actually doing 3. Perform database truncation (Derby only) only inside buildTestRule. No need to do it also as part of the class rule 4. Handle metastore configuration exclusively in buildClassRule. We need to set the configuration only once before the first test runs and this is exactly what happens if we put it in the class rule. 5. Drop firstTestNotYetRun flag along with related code since there is no longer overlapping logic between test and class rule. 6. Drop now redundant QTestMetastoreHandler#beforeTest method
|
I guess this PR can fix the flaky test https://ci.hive.apache.org/blue/organizations/jenkins/hive-precommit/detail/PR-5884/3/tests |
|
@zhangbutao That's exactly what is fixing :D |
zhangbutao
approved these changes
Jun 27, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request and why?
Does this PR introduce any user-facing change?
No
How was this patch tested?
Run the following and after each verified (using
docker ps) that no container is running.