Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-17806: remove this-escape suppress warnings in AclCommand #19256

Merged
merged 1 commit into from
Mar 21, 2025

Conversation

FrankYang0529
Copy link
Member

@FrankYang0529 FrankYang0529 commented Mar 20, 2025

Change AclCommandOptions to final class, so we can remove @SuppressWarnings("this-escape") on it.

Reviewers: Chia-Ping Tsai chia7712@gmail.com

Signed-off-by: PoAn Yang <payang@apache.org>
@github-actions github-actions bot added tools small Small PRs labels Mar 20, 2025
@FrankYang0529 FrankYang0529 requested a review from chia7712 March 21, 2025 01:31
Copy link
Member

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chia7712 chia7712 merged commit 1260b6d into apache:trunk Mar 21, 2025
24 checks passed
@FrankYang0529 FrankYang0529 deleted the KAFKA-17806 branch March 21, 2025 23:59
ShivsundarR pushed a commit to ShivsundarR/kafka that referenced this pull request Mar 26, 2025
…e#19256)

Change AclCommandOptions to final class, so we can remove
`@SuppressWarnings("this-escape")` on it.

Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants