Skip to content

chore: Remove special characters before calling xargs in notify comment #3661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 24, 2025

Conversation

mattcreaser
Copy link
Member

Issue #, if available:

Description of changes:
Remove special characters when invoking the slack webhook for issue comments. This prevents failures from comments that have e.g. quotes in them.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@mattcreaser mattcreaser requested a review from a team as a code owner March 10, 2025 12:13
@mattcreaser mattcreaser enabled auto-merge (squash) June 24, 2025 14:26
@mattcreaser mattcreaser merged commit 4a6b0b3 into main Jun 24, 2025
1 check passed
@mattcreaser mattcreaser deleted the mattcreaser/notify-comments-special-chars branch June 24, 2025 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants