Codecommit deprecation #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tag invalid: The image tag 'latest' already exists in the 'helloworld' repository and cannot be overwritten because the repository is immutable.
ERROR: unable to select packages:
libcrypto3-3.3.2-r1:
breaks: world[libcrypto3=3.0.8-r0]
satisfies: libssl3-3.3.2-r1[libcrypto3=3.3.2-r1]
libssl3-3.3.2-r1[so:libcrypto.so.3]
wget-1.24.5-r0[so:libcrypto.so.3]
apk-tools-2.14.4-r1[so:libcrypto.so.3]
libssl3-3.3.2-r1:
breaks: world[libssl3=3.0.8-r0]
satisfies: wget-1.24.5-r0[so:libssl.so.3]
apk-tools-2.14.4-r1[so:libssl.so.3]
durdina
commented
Jan 17, 2025
| @@ -10,7 +10,6 @@ phases: | |||
| - apt-get install -y wget apt-transport-https gnupg lsb-release curl | |||
| - curl -OL https://github.com/aws/aws-codeguru-cli/releases/download/0.2.3/aws-codeguru-cli.zip | |||
| - unzip aws-codeguru-cli.zip | |||
| - export PATH=$PATH:./aws-codeguru-cli/bin | |||
There was a problem hiding this comment.
Not needed as command is executed with full path $BASE/aws-codeguru-cli/bin/aws-codeguru-cli
durdina
commented
Jan 17, 2025
| @@ -341,6 +341,8 @@ Resources: | |||
| - s3:GetObject | |||
| - s3:GetObjectVersion | |||
| - s3:GetBucketVersioning | |||
| - s3:DeleteObject | |||
There was a problem hiding this comment.
There were warnings in build.log if these permissions were missing:
Started new CodeGuru Reviewer scan: https://console.aws.amazon.com/codeguru/reviewer?region=us-east-1#/codereviews/details/arn:aws:codeguru-reviewer:us-east-1:840195444908:association:a36fcc80-a61e-44e3-b340-8f8966a79d12:code-review:PullRequest-codeguru-reviewer-cli-9b840f09-21ce-461d-832e-0e61ea2ae8cd
................................................................................:)
Failed to delete analysis-src-fb1f9859-d7c8-41c2-9993-4f194ee256b2.zip from codeguru-reviewer-cli-840195444908-us-east-1. Please delete the object by hand.
Failed to delete analysis-bin-ab374d09-b686-4a1b-b746-43d9460a3cbc.zip from codeguru-reviewer-cli-840195444908-us-east-1. Please delete the object by hand.
durdina
commented
Jan 17, 2025
| @@ -618,8 +608,6 @@ Resources: | |||
| Artifacts: | |||
| Type: CODEPIPELINE | |||
| Source: | |||
| Location: | |||
There was a problem hiding this comment.
Location is ignored in conjunction with Type: CODEPIPELINE.
durdina
commented
Jan 17, 2025
| DockerRepo: | ||
| Type: AWS::ECR::Repository | ||
| Properties: | ||
| ImageTagMutability: IMMUTABLE | ||
| ImageTagMutability: MUTABLE |
There was a problem hiding this comment.
With ImageTagMutability: IMMUTABLE repeated runs of code pipeline failed with the following error
tag invalid: The image tag 'latest' already exists in the 'helloworld' repository and cannot be overwritten because the repository is immutable.
durdina
commented
Jan 17, 2025
| RUN mkdir -p /opt/target | ||
| RUN apk update && apk add wget && wget $CODEGURU_PROFILER_AGENT_DOWNLOAD_URL -O /opt/target/codeguru-profiler-java-agent-standalone.jar | ||
| RUN apk add libcrypto3=3.0.8-r0 libssl3=3.0.8-r0 | ||
| RUN apk add --upgrade libcrypto3 libssl3 |
There was a problem hiding this comment.
This caused an error:
Step 9/16 : RUN apk add libcrypto3=3.0.8-r0 libssl3=3.0.8-r0
---> Running in 43106c860328
ERROR: unable to select packages:
libcrypto3-3.3.2-r1:
breaks: world[libcrypto3=3.0.8-r0]
satisfies: libssl3-3.3.2-r1[libcrypto3=3.3.2-r1]
libssl3-3.3.2-r1[so:libcrypto.so.3]
wget-1.24.5-r0[so:libcrypto.so.3]
apk-tools-2.14.4-r1[so:libcrypto.so.3]
libssl3-3.3.2-r1:
breaks: world[libssl3=3.0.8-r0]
satisfies: wget-1.24.5-r0[so:libssl.so.3]
apk-tools-2.14.4-r1[so:libssl.so.3]
The command '/bin/sh -c apk add libcrypto3=3.0.8-r0 libssl3=3.0.8-r0' returned a non-zero code: 4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue , if available: #6
Description of changes: Replacing dependency on AWS CodeCommit with GitHub for fetching source code in the source stage of CI/CD pipeline produced by this project.
There are some additional improvements organized as separate commits. Their respective documentation is in their commit messages. I am happy to split this PR into multiple PRs if would make the review easier.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.