Fixing race conditions in transferProgressListenerTest #5985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RanVaknin
force-pushed
the
rvaknin/fix-integ-S3JavaMultipartTransferProgressListenerTest
branch
from
56c9dd4 to
1339675
Compare
|
L-Applin
approved these changes
Mar 25, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Tests in this class are intermittently failing due to a race condition. Expanding the verify clause with a
timeoutallows for padding and polling reducing the failure rate almost to 0%.Testing
Ran all of those test cases with a
@RepeatedTest(500)wrapper and observed an error rate of 0.7%After adding timeout I ran the wrapper multiple times and observed 0% failures (local environment testing only).