Bump OpenRewrite to 3.6.1

test/v2-migration-tests/pom.xml

@@ -136,6 +136,11 @@
             <artifactId>test-utils</artifactId>
             <scope>test</scope>
         </dependency>
+        <dependency>
+            <groupId>commons-io</groupId>
+            <artifactId>commons-io</artifactId>
+            <scope>test</scope>
+        </dependency>
     </dependencies>
 
     <build>

test/v2-migration-tests/src/test/java/software/amazon/awssdk/v2migrationtests/GradleProjectTest.java

@@ -36,7 +36,6 @@
 import org.junit.jupiter.api.BeforeAll;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.condition.EnabledIf;
-import software.amazon.awssdk.testutils.SdkVersionUtils;
 import software.amazon.awssdk.utils.Logger;
 
 public class GradleProjectTest {

test/v2-migration-tests/src/test/java/software/amazon/awssdk/v2migrationtests/MavenTestBase.java

@@ -55,7 +55,7 @@ protected static void verifyTransformation(boolean experimental) throws IOExcept
 
         List<String> rewriteArgs = new ArrayList<>();
         // pin version since updates have broken tests
-        String rewriteMavenPluginVersion = "5.46.0";
+        String rewriteMavenPluginVersion = "6.6.0";
         addAll(rewriteArgs, "mvn", "org.openrewrite.maven:rewrite-maven-plugin:" + rewriteMavenPluginVersion + ":run",
                "-Drewrite.recipeArtifactCoordinates=software.amazon.awssdk:v2-migration:"+ getMigrationToolVersion() + "-PREVIEW",
                recipeCmd);

test/v2-migration-tests/src/test/resources/software/amazon/awssdk/v2migrationtests/gradle/before/init.gradle

@@ -3,7 +3,7 @@ initscript {
         maven { url "https://plugins.gradle.org/m2" }
     }
     dependencies {
-        classpath("org.openrewrite:plugin:6.28.0")
+        classpath("org.openrewrite:plugin:7.4.1")
     }
 }
 

test/v2-migration-tests/src/test/resources/software/amazon/awssdk/v2migrationtests/maven/after/src/main/java/foo/bar/S3Streaming.java

@@ -61,7 +61,7 @@ void putObject_bucketKeyStreamMetadata(String bucket, String key, InputStream st
         HeadObjectResponse metadataWithLength = HeadObjectResponse.builder()
             .build();
         s3.putObject(PutObjectRequest.builder().bucket(bucket).key(key).contentLength(22L)
-            .build(), RequestBody.fromInputStream(stream, 22L));
+            .build(), RequestBody.fromInputStream(stream, 22));
 
 
         HeadObjectResponse metadataWithoutLength = HeadObjectResponse.builder()
@@ -105,7 +105,7 @@ void putObject_requestPojoWithInputStream(String bucket, String key) {
         HeadObjectResponse metadata = HeadObjectResponse.builder()
             .build();
         s3.putObject(PutObjectRequest.builder().bucket(bucket).key(key).websiteRedirectLocation("location").contentLength(11L)
-            .build(), RequestBody.fromInputStream(inputStream2, 11L));
+            .build(), RequestBody.fromInputStream(inputStream2, 11));
     }
 
     void putObject_requestPojoWithoutPayload(String bucket, String key) {

v2-migration/pom.xml

@@ -34,7 +34,7 @@
 
     <properties>
         <awsjavasdk.version>${project.parent.version}</awsjavasdk.version>
-        <openrewrite.version>2.23.0</openrewrite.version>
+        <openrewrite.version>3.6.1</openrewrite.version>
         <junit.version>5.10.3</junit.version>
         <awssdkjavav1.version>1.12.472</awssdkjavav1.version>
     </properties>

v2-migration/src/main/java/software/amazon/awssdk/v2migration/S3PutObjectRequestToV2.java

@@ -305,13 +305,8 @@ private J.MethodInvocation addInputStreamToPutObject(J.MethodInvocation method,
                     .withComments(inputStreamBufferingWarningComment());
             }
 
-            StringBuilder sb = new StringBuilder("#{any()}, RequestBody.fromInputStream(#{any()}, #{any()}");
-            if (contentLen instanceof J.Literal) {
-                sb.append("L");
-            }
-            sb.append(")");
-
-            return JavaTemplate.builder(sb.toString()).build()
+            v2Method = "#{any()}, RequestBody.fromInputStream(#{any()}, #{any()})";
+            return JavaTemplate.builder(v2Method).build()
                                .apply(getCursor(), method.getCoordinates().replaceArguments(),
                                       method.getArguments().get(0), inputStream, contentLen);
         }
@@ -346,12 +341,7 @@ private J.MethodInvocation transformPutObjectWithStreamAndMetadata(J.MethodInvoc
                                    .withComments(inputStreamBufferingWarningComment());
             }
 
-            sb.append(".build(), RequestBody.fromInputStream(#{any()}, #{any()}");
-
-            if (contentLen instanceof J.Literal) {
-                sb.append("L");
-            }
-            sb.append(")");
+            sb.append(".build(), RequestBody.fromInputStream(#{any()}, #{any()})");
 
             params = Arrays.copyOf(params, 4);
             params[3] = contentLen;

v2-migration/src/main/resources/META-INF/rewrite/change-s3-types.yml

@@ -17,82 +17,82 @@ name: software.amazon.awssdk.v2migration.S3TypesToV2
 displayName: Change S3 types to v2.
 description: Change S3 types to v2.
 recipeList:
-  - software.amazon.awssdk.v2migration.openrewrite.ChangeMethodInvocationReturnType:
+  - org.openrewrite.java.ChangeMethodInvocationReturnType:
       methodPattern: com.amazonaws.services.s3.AmazonS3 getObject(com.amazonaws.services.s3.model.GetObjectRequest, java.io.File)
       newReturnType: software.amazon.awssdk.services.s3.model.GetObjectResponse
-  - software.amazon.awssdk.v2migration.openrewrite.ChangeMethodInvocationReturnType:
+  - org.openrewrite.java.ChangeMethodInvocationReturnType:
       methodPattern: com.amazonaws.services.s3.AmazonS3 getBucketAcl(..)
       newReturnType: software.amazon.awssdk.services.s3.model.GetBucketAclResponse
-  - software.amazon.awssdk.v2migration.openrewrite.ChangeMethodInvocationReturnType:
+  - org.openrewrite.java.ChangeMethodInvocationReturnType:
       methodPattern: com.amazonaws.services.s3.AmazonS3 getObjectAcl(..)
       newReturnType: software.amazon.awssdk.services.s3.model.GetObjectAclResponse
-  - software.amazon.awssdk.v2migration.openrewrite.ChangeMethodInvocationReturnType:
+  - org.openrewrite.java.ChangeMethodInvocationReturnType:
       methodPattern: com.amazonaws.services.s3.AmazonS3 getBucketAccelerateConfiguration(..)
       newReturnType: software.amazon.awssdk.services.s3.model.GetBucketAccelerateConfigurationResponse
-  - software.amazon.awssdk.v2migration.openrewrite.ChangeMethodInvocationReturnType:
+  - org.openrewrite.java.ChangeMethodInvocationReturnType:
       methodPattern: com.amazonaws.services.s3.AmazonS3 getBucketLifecycleConfiguration(..)
       newReturnType: software.amazon.awssdk.services.s3.model.GetBucketLifecycleConfigurationResponse
-  - software.amazon.awssdk.v2migration.openrewrite.ChangeMethodInvocationReturnType:
+  - org.openrewrite.java.ChangeMethodInvocationReturnType:
       methodPattern: com.amazonaws.services.s3.AmazonS3 getBucketCrossOriginConfiguration(..)
       newReturnType: software.amazon.awssdk.services.s3.model.GetBucketCorsResponse
-  - software.amazon.awssdk.v2migration.openrewrite.ChangeMethodInvocationReturnType:
+  - org.openrewrite.java.ChangeMethodInvocationReturnType:
       methodPattern: com.amazonaws.services.s3.AmazonS3 getBucketLoggingConfiguration(..)
       newReturnType: software.amazon.awssdk.services.s3.model.GetBucketLoggingResponse
-  - software.amazon.awssdk.v2migration.openrewrite.ChangeMethodInvocationReturnType:
+  - org.openrewrite.java.ChangeMethodInvocationReturnType:
       methodPattern: com.amazonaws.services.s3.AmazonS3 getBucketNotificationConfiguration(..)
       newReturnType: software.amazon.awssdk.services.s3.model.GetBucketNotificationConfigurationResponse
-  - software.amazon.awssdk.v2migration.openrewrite.ChangeMethodInvocationReturnType:
+  - org.openrewrite.java.ChangeMethodInvocationReturnType:
       methodPattern: com.amazonaws.services.s3.AmazonS3 getBucketPolicy(..)
       newReturnType: software.amazon.awssdk.services.s3.model.GetBucketPolicyResponse
-  - software.amazon.awssdk.v2migration.openrewrite.ChangeMethodInvocationReturnType:
+  - org.openrewrite.java.ChangeMethodInvocationReturnType:
       methodPattern: com.amazonaws.services.s3.AmazonS3 getBucketReplicationConfiguration(..)
       newReturnType: software.amazon.awssdk.services.s3.model.GetBucketReplicationResponse
-  - software.amazon.awssdk.v2migration.openrewrite.ChangeMethodInvocationReturnType:
+  - org.openrewrite.java.ChangeMethodInvocationReturnType:
       methodPattern: com.amazonaws.services.s3.AmazonS3 getBucketTaggingConfiguration(..)
       newReturnType: software.amazon.awssdk.services.s3.model.GetBucketTaggingResponse
-  - software.amazon.awssdk.v2migration.openrewrite.ChangeMethodInvocationReturnType:
+  - org.openrewrite.java.ChangeMethodInvocationReturnType:
       methodPattern: com.amazonaws.services.s3.AmazonS3 getBucketVersioningConfiguration(..)
       newReturnType: software.amazon.awssdk.services.s3.model.GetBucketVersioningResponse
-  - software.amazon.awssdk.v2migration.openrewrite.ChangeMethodInvocationReturnType:
+  - org.openrewrite.java.ChangeMethodInvocationReturnType:
       methodPattern: com.amazonaws.services.s3.AmazonS3 getBucketWebsiteConfiguration(..)
       newReturnType: software.amazon.awssdk.services.s3.model.GetBucketWebsiteResponse
 
-  - software.amazon.awssdk.v2migration.openrewrite.ChangeMethodInvocationReturnType:
+  - org.openrewrite.java.ChangeMethodInvocationReturnType:
       methodPattern: com.amazonaws.services.s3.AmazonS3Client getObject(com.amazonaws.services.s3.model.GetObjectRequest, java.io.File)
       newReturnType: software.amazon.awssdk.services.s3.model.GetObjectResponse
-  - software.amazon.awssdk.v2migration.openrewrite.ChangeMethodInvocationReturnType:
+  - org.openrewrite.java.ChangeMethodInvocationReturnType:
       methodPattern: com.amazonaws.services.s3.AmazonS3Client getBucketAcl(..)
       newReturnType: software.amazon.awssdk.services.s3.model.GetBucketAclResponse
-  - software.amazon.awssdk.v2migration.openrewrite.ChangeMethodInvocationReturnType:
+  - org.openrewrite.java.ChangeMethodInvocationReturnType:
       methodPattern: com.amazonaws.services.s3.AmazonS3Client getObjectAcl(..)
       newReturnType: software.amazon.awssdk.services.s3.model.GetObjectAclResponse
-  - software.amazon.awssdk.v2migration.openrewrite.ChangeMethodInvocationReturnType:
+  - org.openrewrite.java.ChangeMethodInvocationReturnType:
       methodPattern: com.amazonaws.services.s3.AmazonS3Client getBucketAccelerateConfiguration(..)
       newReturnType: software.amazon.awssdk.services.s3.model.GetBucketAccelerateConfigurationResponse
-  - software.amazon.awssdk.v2migration.openrewrite.ChangeMethodInvocationReturnType:
+  - org.openrewrite.java.ChangeMethodInvocationReturnType:
       methodPattern: com.amazonaws.services.s3.AmazonS3Client getBucketLifecycleConfiguration(..)
       newReturnType: software.amazon.awssdk.services.s3.model.GetBucketLifecycleConfigurationResponse
-  - software.amazon.awssdk.v2migration.openrewrite.ChangeMethodInvocationReturnType:
+  - org.openrewrite.java.ChangeMethodInvocationReturnType:
       methodPattern: com.amazonaws.services.s3.AmazonS3Client getBucketCrossOriginConfiguration(..)
       newReturnType: software.amazon.awssdk.services.s3.model.GetBucketCorsResponse
-  - software.amazon.awssdk.v2migration.openrewrite.ChangeMethodInvocationReturnType:
+  - org.openrewrite.java.ChangeMethodInvocationReturnType:
       methodPattern: com.amazonaws.services.s3.AmazonS3Client getBucketLoggingConfiguration(..)
       newReturnType: software.amazon.awssdk.services.s3.model.GetBucketLoggingResponse
-  - software.amazon.awssdk.v2migration.openrewrite.ChangeMethodInvocationReturnType:
+  - org.openrewrite.java.ChangeMethodInvocationReturnType:
       methodPattern: com.amazonaws.services.s3.AmazonS3Client getBucketNotificationConfiguration(..)
       newReturnType: software.amazon.awssdk.services.s3.model.GetBucketNotificationConfigurationResponse
-  - software.amazon.awssdk.v2migration.openrewrite.ChangeMethodInvocationReturnType:
+  - org.openrewrite.java.ChangeMethodInvocationReturnType:
       methodPattern: com.amazonaws.services.s3.AmazonS3Client getBucketPolicy(..)
       newReturnType: software.amazon.awssdk.services.s3.model.GetBucketPolicyResponse
-  - software.amazon.awssdk.v2migration.openrewrite.ChangeMethodInvocationReturnType:
+  - org.openrewrite.java.ChangeMethodInvocationReturnType:
       methodPattern: com.amazonaws.services.s3.AmazonS3Client getBucketReplicationConfiguration(..)
       newReturnType: software.amazon.awssdk.services.s3.model.GetBucketReplicationResponse
-  - software.amazon.awssdk.v2migration.openrewrite.ChangeMethodInvocationReturnType:
+  - org.openrewrite.java.ChangeMethodInvocationReturnType:
       methodPattern: com.amazonaws.services.s3.AmazonS3Client getBucketTaggingConfiguration(..)
       newReturnType: software.amazon.awssdk.services.s3.model.GetBucketTaggingResponse
-  - software.amazon.awssdk.v2migration.openrewrite.ChangeMethodInvocationReturnType:
+  - org.openrewrite.java.ChangeMethodInvocationReturnType:
       methodPattern: com.amazonaws.services.s3.AmazonS3Client getBucketVersioningConfiguration(..)
       newReturnType: software.amazon.awssdk.services.s3.model.GetBucketVersioningResponse
-  - software.amazon.awssdk.v2migration.openrewrite.ChangeMethodInvocationReturnType:
+  - org.openrewrite.java.ChangeMethodInvocationReturnType:
       methodPattern: com.amazonaws.services.s3.AmazonS3Client getBucketWebsiteConfiguration(..)
       newReturnType: software.amazon.awssdk.services.s3.model.GetBucketWebsiteResponse

v2-migration/src/test/java/software/amazon/awssdk/v2migration/ChangeConfigTypesTest.java

@@ -29,6 +29,7 @@
 import org.openrewrite.java.Java8Parser;
 import org.openrewrite.test.RecipeSpec;
 import org.openrewrite.test.RewriteTest;
+import org.openrewrite.test.TypeValidation;
 
 public class ChangeConfigTypesTest implements RewriteTest {
 
@@ -46,7 +47,8 @@ public void defaults(RecipeSpec spec) {
             throw new RuntimeException(e);
         }
 
-        spec.parser(Java8Parser.builder().classpath("aws-java-sdk-sqs", "sdk-core"));
+        spec.parser(Java8Parser.builder().classpath("aws-java-sdk-sqs", "sdk-core"))
+            .typeValidationOptions(TypeValidation.all().immutableExecutionContext(false));
     }
 
     @Test