ref(vmpu): Standardize vMPU driver #216
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miguelafsilva5
force-pushed
the
ref/vmpu
branch
5 times, most recently
from
063a1b2 to
2f167aa
Compare
src/core/mpu/mem.c
Outdated
| @@ -546,7 +587,7 @@ vaddr_t mem_map_cpy(struct addr_space* ass, struct addr_space* asd, vaddr_t vas, | |||
| mpr = mpe->region; | |||
| spin_unlock(&ass->lock); | |||
|
|
|||
| if (mem_map(asd, &mpr, true)) { | |||
| if (mem_map(asd, &mpr, true, false)) { | |||
There was a problem hiding this comment.
Just a note that I think these type of invocations are not easily readable.
It would be best to have some macros (e.g., MPU_ENTRY_LOCKED, MPU_ENTRY_UNLOCKED) and used inplace of the true/false values which add little semantic information
There was a problem hiding this comment.
I agree with you. However, this false/true might not reflect if the entry will be locked or not. It's just a "guideline" for later functions to decide if the entry is locked or not.
| @@ -164,7 +164,7 @@ static void mem_init_boot_regions(void) | |||
| .mem_flags = PTE_HYP_FLAGS, | |||
| .as_sec = SEC_HYP_IMAGE, | |||
| }; | |||
| mem_map(&cpu()->as, &mpr, true, true); | |||
| mem_map(&cpu()->as, &mpr, false, true); | |||
There was a problem hiding this comment.
Similarly to a comment I made before, It would be best to have some macros (e.g., MPU_BROADCAST, MPU_NO_BROADCAST) used in place of the true/false values which add little semantic information
There was a problem hiding this comment.
Similar to the locked comment. Later functions decide if the regions need to be broadcast or not.
miguelafsilva5
force-pushed
the
ref/vmpu
branch
7 times, most recently
from
d1eb470 to
327ac4a
Compare
Signed-off-by: Jose Martins <josemartins90@gmail.com>
Signed-off-by: Jose Martins <josemartins90@gmail.com>
Added an ordered list structure to the vmpu to facilitate the merge of regions. Signed-off-by: Daniel Oliveira <drawnpoetry@gmail.com>
Add functionality to lock entries on the vMPU to prevent hypervisor MPU entries from being removed. Signed-off-by: Daniel Oliveira <drawnpoetry@gmail.com>
This API simplifies the implementation of vMPU entries coalescense. Updating a region requires a broadcast to the other CPUs on the same address space. This commit also fixes the install of the VM images where MPU entries on other cores were not correctly unmaped. Signed-off-by: Daniel Oliveira <drawnpoetry@gmail.com> Signed-off-by: Miguel Silva <miguelafsilva5@gmail.com>
danielRep
force-pushed
the
ref/vmpu
branch
2 times, most recently
from
0c17b42 to
1fa7ca3
Compare
danielRep
force-pushed
the
ref/vmpu
branch
4 times, most recently
from
ef8a1ee to
91a5c37
Compare
Comment on lines
+175
to
+184
| bool mpu_perms_compatible(unsigned long perms1, unsigned long perms2) | ||
| { | ||
| bitmap_clear_consecutive(cpu()->arch.profile.mpu.bitmap, 0, mpu_num_entries()); | ||
| list_init(&cpu()->arch.profile.mpu.order.list); | ||
| UNUSED_ARG(perms1); | ||
| UNUSED_ARG(perms2); | ||
|
|
||
| for (mpid_t mpid = 0; mpid < (mpid_t)mpu_num_entries(); mpid++) { | ||
| cpu()->arch.profile.mpu.order.node[mpid].mpid = mpid; | ||
| return true; | ||
| } |
There was a problem hiding this comment.
How to check mpu perm compaibility?
miguelafsilva5
force-pushed
the
ref/vmpu
branch
3 times, most recently
from
d0026bd to
0a52b3e
Compare
This reduces the number of vMPU/MPU entries. Signed-off-by: Daniel Oliveira <drawnpoetry@gmail.com> Signed-off-by: Miguel Silva <miguelafsilva5@gmail.com>
To simplify boot code we run with mpu disable until the mem init. Signed-off-by: Daniel Oliveira <drawnpoetry@gmail.com>
Initally, when mapping and copying, the destination region was being created with the same size of the original region, instead of the size of the data being copied Signed-off-by: Miguel Silva <miguelafsilva5@gmail.com>
Removed the complexity from the MPU driver related to the merge of regions, which was moved to the vMPU level. Removed the creation of MPU entries during boot. Signed-off-by: Miguel Silva <miguelafsilva5@gmail.com>
During the context switch of MPU regions, locked entries are not disabled. Signed-off-by: Miguel Silva <miguelafsilva5@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This PR aims to stantardize the vMPU driver and to the some extend the MPU API. This was needed to support different MPU implementations.
A major goal of this PR is remove the complexity from the MPU driver and move it to the vMPU.
The history of this PR still has to be reviewed.
Current MPU implementation have to be updated to comply with this PR.