Skip to content

Commit 6eb447a

Browse files
ktaborsLFDanLusnowystinger
authoredOct 2, 2020
switching to inline flex to stop ComboBox jumping in safari (adobe#984)
* switching to inline flex to stop jumping in safari * changing vertical alignment of sibling button group Co-authored-by: Daniel Lu <dlu@livefyre.com> Co-authored-by: Robert Snow <rsnow@adobe.com>
1 parent c5f4a77 commit 6eb447a

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed
 

‎packages/@adobe/spectrum-css-temp/components/fieldlabel/index.css

+2-1
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,8 @@ governing permissions and limitations under the License.
6363
* and this causes both the label and inner field to resize as well. */
6464
.spectrum-Field {
6565
&.spectrum-Field--positionTop {
66-
display: inline-block;
66+
display: inline-flex;
67+
flex-direction: column;
6768
width: var(--spectrum-component-single-line-width);
6869

6970
.spectrum-Field-field {

‎packages/@react-spectrum/combobox/stories/ComboBox.stories.tsx

+2-2
Original file line numberDiff line numberDiff line change
@@ -321,7 +321,7 @@ let ControlledKeyComboBox = (props) => {
321321
return (
322322
<div>
323323
<div>Current selectedKey: {selectedKey}</div>
324-
<ButtonGroup marginEnd="30px">
324+
<ButtonGroup marginEnd="30px" UNSAFE_style={{verticalAlign: 'bottom'}}>
325325
<Button variant="secondary" onPress={() => setSelectedKey('3')}>
326326
<Text>Snake</Text>
327327
</Button>
@@ -353,7 +353,7 @@ let ControlledValueComboBox = (props) => {
353353
return (
354354
<div>
355355
<div>Current input value: {value}</div>
356-
<ButtonGroup marginEnd="30px">
356+
<ButtonGroup marginEnd="30px" UNSAFE_style={{verticalAlign: 'bottom'}}>
357357
<Button variant="secondary" onPress={() => setValue('Blah')}>
358358
<Text>Blah</Text>
359359
</Button>

0 commit comments

Comments
 (0)
Failed to load comments.