Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(localizations): Define that you have to enter the current password #5455

Merged
merged 3 commits into from
Mar 26, 2025

Conversation

octoper
Copy link
Member

@octoper octoper commented Mar 26, 2025

Description

This PR changes the password re-verification flow description to define that you need to enter the current password

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Copy link

changeset-bot bot commented Mar 26, 2025

🦋 Changeset detected

Latest commit: 85efbac

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@clerk/localizations Patch
@clerk/clerk-js Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@octoper octoper self-assigned this Mar 26, 2025
Copy link

vercel bot commented Mar 26, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 26, 2025 11:49am

@octoper octoper requested review from chanioxaris and panteliselef and removed request for chanioxaris March 26, 2025 11:43
@octoper octoper changed the title fix(localization): Define that you have to enter the current password fix(localizations): Define that you have to enter the current password Mar 26, 2025
@octoper octoper requested review from chanioxaris and kostaspt March 26, 2025 11:45
Copy link
Member

@panteliselef panteliselef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "current" is redundant for flows except the one for updating the password. But this seems ok.

@octoper octoper merged commit a570b80 into main Mar 26, 2025
30 checks passed
@octoper octoper deleted the vaggelis/change-password-reverification-description branch March 26, 2025 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants