Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC-12391 Add link to hotspots doc from other related pages #19463

Merged
merged 6 commits into from
Mar 24, 2025

Conversation

florence-crl
Copy link
Contributor

@florence-crl florence-crl commented Mar 20, 2025

Fixes DOC-12391

Replaced hot spot with hotspot to be consistent with understand-hotspots.md.
Renamed include file to reduce-hotspots.md.
Replaced links to performance-best-practices-overview.md Hotspots section with links to understand-hotspots.md.
Added links to understand-hotspots.md.
In performance-best-practices-overview.md, removed Reduce hotspots section.
In understand-hotspots.md, added Reduce hotspots section and corrected spelling of Queueing hotspot.

Rendered preview

Renamed include file to reduce-hotspots.md.

In ui-key-visualizer.md, fixed links.

In performance-best-practices-overview.md, performance-recipes, recommended-production-settings.md, common-issues-to-monitor.md, added links to understand-hotspots.md.

In variables.md include file, linked queue-like workload to Queueing hotspot.

In understand-hotspots.md, corrected spelling of Queueing hotspot.
Copy link

github-actions bot commented Mar 20, 2025

Files changed:

Copy link

netlify bot commented Mar 20, 2025

Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit 92fb99a
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-api-docs/deploys/67e1786710a6a200080baf46

Copy link

netlify bot commented Mar 20, 2025

Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit 92fb99a
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-interactivetutorials-docs/deploys/67e17867f918b10008c8bdd2

Copy link

netlify bot commented Mar 20, 2025

Netlify Preview

Name Link
🔨 Latest commit 92fb99a
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-docs/deploys/67e17867ac7b47000806ef28
😎 Deploy Preview https://deploy-preview-19463--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

…tion with links to understand-hotspots.

In performance-best-practices-overview.md, removed Reduce hotspots section.

In understand-hotspots.md, added Reduce hotspots section.

In other files, added links to understand-hotspots.md.
@florence-crl florence-crl requested a review from katmayb March 24, 2025 14:16
Copy link
Contributor

@katmayb katmayb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one non-blocking comment that I'm not sure is correct or not!

Copy link
Contributor Author

@florence-crl florence-crl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tftr

@florence-crl florence-crl merged commit 07d3dd1 into main Mar 24, 2025
6 checks passed
@florence-crl florence-crl deleted the DOC-12391 branch March 24, 2025 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants