Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Update Toolbar tests #9479

Merged
merged 1 commit into from
Mar 7, 2025
Merged

refactor: Update Toolbar tests #9479

merged 1 commit into from
Mar 7, 2025

Conversation

neznaika0
Copy link
Contributor

Description
Fix phpstan error:

 ------ --------------------------------------------------------------------------------------------- 
  Line   tests/system/Filters/DebugToolbarTest.php                                                    
 ------ --------------------------------------------------------------------------------------------- 
  :63    Call to method CodeIgniter\Filters\DebugToolbar::before() on a separate line has no effect.  
         🪪  method.resultUnused                                                                      
 ------ ---------------------------------------------------------------------------------------------

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@paulbalandan paulbalandan merged commit 236dca3 into codeigniter4:develop Mar 7, 2025
48 checks passed
@neznaika0 neznaika0 deleted the refactor/toolbar-test branch March 7, 2025 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulbalandan paulbalandan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neznaika0 @paulbalandan