Resolves NPE when opening app without location permission and mobile data #6345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -569,7 +569,7 @@ class NearbyParentFragmentPresenter | |||
| loadPlacesDataAyncJob?.cancel() | |||
| localPlaceSearchJob = scope.launch(Dispatchers.IO) { | |||
| delay(LOCAL_SCROLL_DELAY) | |||
| val mapFocus = nearbyParentFragmentView.mapFocus | |||
| val mapFocus = nearbyParentFragmentView.mapFocus ?: return@launch | |||
There was a problem hiding this comment.
to handle the case when Permission dialog is active above NearbyParentFragment leading to null values for nearbyParentFragment.mapFocus, nearbyParentFragment.screenBottomLeft and nearbyParentFragment.screenTopRight
Haven't tested yet but the NPE is happening at fetchPlaces() if I understand the logs correctly. Just thinking: can we still have cases where the other two could be null and we end up passing them to this function? Should we handle all of them since these are completely independent values and not calculated using any one of them?
|
✅ Generated APK variants! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes NPE when opening app without location permission and mobile data
Fixes #6330
Added Null Check for
NearbyParentFragment.mapFocusto handle the case when Permission dialog is active aboveNearbyParentFragmentleading to null values fornearbyParentFragment.mapFocus,nearbyParentFragment.screenBottomLeftandnearbyParentFragment.screenTopRight.Reproduce Issue by:
ask every time.Before Fix
6330-before.mp4
After Fix
6330-after.mp4
Tested on:
Device : Pixel 8
API Level: 35