Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nflog and silences metrics #6659

Conversation

SungJin1212
Copy link
Member

The alertmanager v0.26.0 added maintenance metrics for nflog and silences. This PR adds these metrics to the Cortex.
Added metrics are:

  • cortex_alertmanager_nflog_maintenance_total
  • cortex_alertmanager_nflog_maintenance_errors_total
  • cortex_alertmanager_silences_maintenance_total
  • cortex_alertmanager_silences_maintenance_errors_total

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Tests updated
  • [NA] Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Copy link
Contributor

@danielblando danielblando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Copy link
Contributor

@rajagopalanand rajagopalanand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Just need to fix changelog

Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
@SungJin1212 SungJin1212 force-pushed the Add-alertmanager-nflog-silences-metrics branch from b783cdc to 554a569 Compare March 26, 2025 05:51
@danielblando danielblando merged commit 393a672 into cortexproject:master Mar 26, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants