Update owo-colors #1578
Closed
Update owo-colors #1578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayvdb
commented
Oct 23, 2024
| impl Stream for io::Stdin { | ||
| type TTY = io::Stdin; | ||
| const OWO: owo_colors::Stream = owo_colors::Stream::Stdin; | ||
| const OWO: Option<owo_colors::Stream> = None; |
Author
There was a problem hiding this comment.
Another option is to do const OWO: owo_colors::Stream = owo_colors::Stream::Stdout; here even though that is wrong, but it avoids the Option and the unwrap().
Or split the trait. I was a bit worried as it is pub. OTOH, probably nobody else is using the lib.
Member
There was a problem hiding this comment.
Breaking the api is fine. We dont guarantee that its stable
Line 8 in 4090bec
Contributor
|
Superseded by #1708, I believe. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes one of the atty dependencies