refs #13698 - Library: avoid impossible type lookups

[firewave]

No description provided.

[firewave]

Okay - this appears to be quite a mess (surprise, surprise).

The function declaration stuff has lots of other cases. And I am also seeing function calls getting through which do not seem to be recognized as such.

[firewave]

And I am also seeing function calls getting through which do not seem to be recognized as such.

I wonder if that is a chicken/egg issue. In the --dump output it is associated with a function but in the lookup it isn't. I guess because that relation has not yet been established at that point.

Maybe those type lookups need to be deferred?

[firewave]

@chrchr-github could you please have a look at this? Thanks.

[chrchr-github]

Off the top of my head, you could try something like this

if (tok->str() == "::")
    tok = tok->next();
while (Token::Match(tok, "%name% ::")) {
    typestr += tok->str();
    typestr += "::";
    tok = tok->tokAt(2);
}
if (tok && tok->isName()) {
    typestr += tok->str();
}

[firewave]

Thanks. That's probably as convoluted as what I would have come up with (if I had tried). I was hoping there might be something more straight forward I was missing.

[firewave]

Thanks. That produces proper types to look up. Published in #7378.