Skip to content

[infra] bump lint packages #2359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

goderbauer
Copy link
Contributor

@goderbauer goderbauer commented Jun 13, 2025

Bumping the linting related packages:

  • pkg:dart_flutter_team_lints to 3.5.2
  • pkg:lints to 6.0.0
  • pkg:flutter_lints to 6.0.0

Copy link

github-actions bot commented Jun 13, 2025

PR Health

Changelog Entry
Package Changed Files
package:code_assets pkgs/code_assets/pubspec.yaml
package:data_assets pkgs/data_assets/pubspec.yaml
package:ffi pkgs/ffi/pubspec.yaml
package:hooks pkgs/hooks/example/build/download_asset/pubspec.yaml
pkgs/hooks/example/build/local_asset/pubspec.yaml
pkgs/hooks/example/build/native_add_app/pubspec.yaml
pkgs/hooks/example/build/native_add_library/pubspec.yaml
pkgs/hooks/example/build/native_dynamic_linking/pubspec.yaml
pkgs/hooks/example/build/system_library/pubspec.yaml
pkgs/hooks/example/build/use_dart_api/pubspec.yaml
pkgs/hooks/example/link/app_with_asset_treeshaking/pubspec.yaml
pkgs/hooks/example/link/package_with_assets/pubspec.yaml
pkgs/hooks/pubspec.yaml
package:hooks_runner pkgs/hooks_runner/pubspec.yaml
pkgs/hooks_runner/test_data/add_asset_link/pubspec.yaml
pkgs/hooks_runner/test_data/complex_link/pubspec.yaml
pkgs/hooks_runner/test_data/complex_link_helper/pubspec.yaml
pkgs/hooks_runner/test_data/cyclic_package_1/pubspec.yaml
pkgs/hooks_runner/test_data/cyclic_package_2/pubspec.yaml
pkgs/hooks_runner/test_data/depend_on_fail_build/pubspec.yaml
pkgs/hooks_runner/test_data/depend_on_fail_build_app/pubspec.yaml
pkgs/hooks_runner/test_data/dev_dependency_with_hook/pubspec.yaml
pkgs/hooks_runner/test_data/drop_dylib_link/pubspec.yaml
pkgs/hooks_runner/test_data/fail_build/pubspec.yaml
pkgs/hooks_runner/test_data/fail_on_os_sdk_version/pubspec.yaml
pkgs/hooks_runner/test_data/fail_on_os_sdk_version_link/pubspec.yaml
pkgs/hooks_runner/test_data/fail_on_os_sdk_version_linker/pubspec.yaml
pkgs/hooks_runner/test_data/infra_failure/pubspec.yaml
pkgs/hooks_runner/test_data/native_add/pubspec.yaml
pkgs/hooks_runner/test_data/native_add_add_source/pubspec.yaml
pkgs/hooks_runner/test_data/native_add_duplicate/pubspec.yaml
pkgs/hooks_runner/test_data/native_add_version_skew/pubspec.yaml
pkgs/hooks_runner/test_data/native_add_version_skew_2/pubspec.yaml
pkgs/hooks_runner/test_data/native_dynamic_linking/pubspec.yaml
pkgs/hooks_runner/test_data/native_subtract/pubspec.yaml
pkgs/hooks_runner/test_data/no_asset_for_link/pubspec.yaml
pkgs/hooks_runner/test_data/no_hook/pubspec.yaml
pkgs/hooks_runner/test_data/package_reading_metadata/pubspec.yaml
pkgs/hooks_runner/test_data/package_with_metadata/pubspec.yaml
pkgs/hooks_runner/test_data/relative_path/pubspec.yaml
pkgs/hooks_runner/test_data/reusable_dynamic_library/pubspec.yaml
pkgs/hooks_runner/test_data/reuse_dynamic_library/pubspec.yaml
pkgs/hooks_runner/test_data/simple_data_asset/pubspec.yaml
pkgs/hooks_runner/test_data/simple_link/pubspec.yaml
pkgs/hooks_runner/test_data/system_library/pubspec.yaml
pkgs/hooks_runner/test_data/transformer/pubspec.yaml
pkgs/hooks_runner/test_data/treeshaking_native_libs/pubspec.yaml
pkgs/hooks_runner/test_data/use_all_api/pubspec.yaml
pkgs/hooks_runner/test_data/user_defines/pubspec.yaml
pkgs/hooks_runner/test_data/wrong_build_output/pubspec.yaml
pkgs/hooks_runner/test_data/wrong_build_output_2/pubspec.yaml
pkgs/hooks_runner/test_data/wrong_build_output_3/pubspec.yaml
pkgs/hooks_runner/test_data/wrong_linker/pubspec.yaml
pkgs/hooks_runner/test_data/wrong_namespace_asset/pubspec.yaml
package:jni pkgs/jni/example/pubspec.yaml
pkgs/jni/pubspec.yaml
package:native_doc_dartifier pkgs/native_doc_dartifier/pubspec.yaml
package:native_toolchain_c pkgs/native_toolchain_c/pubspec.yaml
package:objective_c pkgs/objective_c/example/pubspec.yaml
pkgs/objective_c/pubspec.yaml

Changes to files need to be accounted for in their respective changelogs.

This check can be disabled by tagging the PR with skip-changelog-check.

API leaks ⚠️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
ffi MallocAllocator
CallocAllocator
jni _JFinalizable
_ReferenceType
_opaque_pthread_mutex_t
_opaque_pthread_cond_t
_Dart_FinalizableHandle
objective_c _FinalizablePointer
_Version

This check can be disabled by tagging the PR with skip-leaking-check.

License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/jni/lib/src/third_party/generated_bindings.dart
pkgs/native_doc_dartifier/example/native_doc_dartifier_example.dart
pkgs/native_doc_dartifier/lib/native_doc_dartifier.dart
pkgs/native_doc_dartifier/lib/src/native_doc_dartifier_base.dart
pkgs/objective_c/lib/src/ns_input_stream.dart

@coveralls
Copy link

coveralls commented Jun 13, 2025

Coverage Status

coverage: 88.001%. remained the same
when pulling e8d108d on goderbauer:bump-linter
into 5eadfaf on dart-lang:main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants