no ex join

Author: nattsw

plugin.rb

@@ -290,33 +290,31 @@ def self.skip_db?
   end
 
   query = <<~SQL
-    WITH x AS (
-      SELECT users.id AS user_id,
-             COUNT(DISTINCT st.topic_id) FILTER (WHERE
-               st.topic_id IS NOT NULL AND
-               t.id IS NOT NULL AND
-               t.archetype <> 'private_message' AND
-               t.deleted_at IS NULL AND
-               p.deleted_at IS NULL
-             ) AS solutions
-      FROM users
-      LEFT JOIN posts p ON p.user_id = users.id
+    UPDATE directory_items di
+    SET solutions = COALESCE(s.solutions, 0)
+    FROM (
+      SELECT
+        u.id AS user_id,
+        COUNT(DISTINCT st.id) FILTER (
+          WHERE st.id IS NOT NULL
+          AND t.id IS NOT NULL
+          AND t.archetype <> 'private_message'
+          AND t.deleted_at IS NULL
+        ) AS solutions
+      FROM users u
+      LEFT JOIN posts p ON p.user_id = u.id AND p.deleted_at IS NULL
       LEFT JOIN discourse_solved_solved_topics st
-             ON st.answer_post_id = p.id
-             AND st.created_at >= :since
+        ON st.answer_post_id = p.id
+        AND st.created_at > :since
       LEFT JOIN topics t ON t.id = st.topic_id
-      WHERE users.id > 0
-        AND users.active
-        AND users.silenced_till IS NULL
-        AND users.suspended_till IS NULL
-      GROUP BY users.id
-    )
-    UPDATE directory_items di
-    SET solutions = x.solutions
-    FROM x
-    WHERE x.user_id = di.user_id
+      WHERE u.id > 0
+        AND u.active
+        AND u.silenced_till IS NULL
+        AND u.suspended_till IS NULL
+      GROUP BY u.id
+    ) s
+    WHERE s.user_id = di.user_id
       AND di.period_type = :period_type
-      AND di.solutions <> x.solutions
   SQL
 
   add_directory_column("solutions", query:)