Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dotenv dependency #290

Merged
merged 5 commits into from
Feb 21, 2024
Merged

Conversation

TheZoker
Copy link
Contributor

Fixes #266

@sdirix
Copy link
Member

sdirix commented Feb 19, 2024

I had a look at this with @lucas-koehler and he brought up a valid statement:

We should just generate a source file with the current version and import this like any other file in the sources. Thereby the version would always be available and there is no need to dynamically fetch it.

Can you adapt the PR accordingly?

@TheZoker
Copy link
Contributor Author

Thanks for the review!
I adapted the logic accordingly.
I also created a default version file, so even without running the ./build.sh script, the app does start without throwing an error.

If you want to place the version file into another directory, please let me know. Also if you want to use other default version, let me know. Thanks!

Copy link
Contributor

@lucas-koehler lucas-koehler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @TheZoker , thanks for the update! LGTM now ✨

@lucas-koehler
Copy link
Contributor

@TheZoker please rebase the changes onto main. I'll merge and squash then.

@lucas-koehler lucas-koehler removed the request for review from sdirix February 21, 2024 13:55
Copy link
Contributor

@lucas-koehler lucas-koehler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the quick updates :)

@lucas-koehler lucas-koehler merged commit 7d68d29 into eclipsesource:master Feb 21, 2024
2 checks passed
@TheZoker TheZoker deleted the remove-dotenv branch February 21, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get rid of docusaurus2-dotenv
3 participants