-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dotenv dependency #290
Conversation
ba861fc
to
53e539e
Compare
I had a look at this with @lucas-koehler and he brought up a valid statement: We should just generate a source file with the current version and import this like any other file in the sources. Thereby the version would always be available and there is no need to dynamically fetch it. Can you adapt the PR accordingly? |
Thanks for the review! If you want to place the version file into another directory, please let me know. Also if you want to use other default version, let me know. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @TheZoker , thanks for the update! LGTM now ✨
@TheZoker please rebase the changes onto main. I'll merge and squash then. |
923e96b
to
cb57d19
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the quick updates :)
Fixes #266