Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Document failWhenUndefined #303

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

skairunner
Copy link
Contributor

In relation to eclipsesource/jsonforms#2396, document failWhenUndefined, provide an example, and link to the API documentation for SchemaBasedCondition.

I also removed the text about type/expectedValue because this is more than a major version out of date and, in my opinion, is confusing. It can be restored if needed.

@CLAassistant
Copy link

CLAassistant commented Nov 26, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I have some minor comments, please check whether you agree with my suggested changes

Co-authored-by: Stefan Dirix <sdirix@eclipsesource.com>
@skairunner skairunner force-pushed the document-failwhenundefined branch from 0d010f3 to ed63fa5 Compare November 26, 2024 13:59
@skairunner
Copy link
Contributor Author

OK, I've applied all the suggestions and cleaned up the commits 👍

Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much ❤️

@sdirix sdirix merged commit c8e7bf5 into eclipsesource:master Nov 26, 2024
2 checks passed
@sdirix
Copy link
Member

sdirix commented Nov 26, 2024

An the change is live. Thank you ;) https://jsonforms.io/docs/uischema/rules/

@skairunner skairunner deleted the document-failwhenundefined branch November 26, 2024 14:29
@skairunner
Copy link
Contributor Author

Happy to help 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants