Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add notes for Tooling 11th March #620

Merged
merged 1 commit into from
Mar 25, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
86 changes: 86 additions & 0 deletions st-embroider/2024/2025-03-11.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,86 @@
# 2025-03-11

Note Taker: Chris Manson
Time Keeper: Chris Manson

## Attendees

Add yourself to the list if you attend and check the box!

- [x] Ed Faulkner (EF)
- [x] Chris Manson (CM)
- [ ] Aaron Chambers (AC)
- [x] Alex (A)
- [x] Preston Sego (PS)
- [x] Simon Ihmig (SI)
- [ ] Katie Gengler (KG)
- [ ] Peter Meehan (PM)
- [ ] Krystan HuffMenne (KH)
- [x] Peter Wagenet (PW)
- [ ] James Davis (JD)
- [x] David Taylor
- [x] Nick Schot
- [x] TommyJR

## Topics

### Project Updates

- Long discussion about v2 addons by default - tracked builtins etc.
- discussion about testing v1 addons with vite
- CM maybe we push on v2 addon by default work?
- added to the agenda
-


### lingering engines issue that was asked about in discord. <@ef4>

- https://github.com/ember-engines/ember-engines/pull/901

- EF: seems like we should update this
- A: we should do ember-cli-update to keep changes in line with upstream
- EF: we need to make sure these changes are included when the update is done
- we need some decision on what happens next
- this PR looks landable



### re-review codemod upgrade to commander - check that we’re happy with api changes (see the test update) https://github.com/embroider-build/embroider/pull/2320 <@mansona>

- looks mostly ok
- EF: I don't like the `--no-` prefix, can we change it?
- CM: I'll see what I can do


### mo’minimal <@NullVoxPopuli>

- https://github.com/embroider-build/embroider/pull/2339
- PS: it would be nice to remove ember-cli
- (general agreement)
- we need to find some way to run tests rather than `ember test`
- testem is still good


### v2 addon by default - non monorepo testing spike <@mansona>

- https://github.com/NullVoxPopuli/my-v2-ember-addon-test-with-tests-test
- EF: we could consider using vite build rather than having a rollup build
- this would benefit from the more minmal resolver
-

### ember-cli-deprecation-workflow as v2 <@simon>

- (summary of the issue)
- we want to upgrade the addon
- EF: it's probably time to introduce an optional feature flag to move all the ember source out of vendor
- this would mean that anything in vendor that depended on deprecate would be broken rather than missed
- a v2 addon can inject code into vendor using the implicit scripts metadata in package.json
- you can see that we're rewriting it already to embroider so we can compare that in embroider
-

### stable decorators update - RFC etc. <@ef4>

- ran out of time, added to next week's agenda



3 changes: 1 addition & 2 deletions st-embroider/template.md
Original file line number Diff line number Diff line change
@@ -7,7 +7,7 @@ Time Keeper:

Add yourself to the list if you attend and check the box!

- [ ] Ed Falkner (EF)
- [ ] Ed Faulkner (EF)
- [ ] Chris Manson (CM)
- [ ] Aaron Chambers (AC)
- [ ] Alex (A)
@@ -18,7 +18,6 @@ Add yourself to the list if you attend and check the box!
- [ ] Krystan HuffMenne (KH)
- [ ] Peter Wagenet (PW)
- [ ] James Davis (JD)
- [ ] Marine Dunstetter (MD)
- [ ] Your name here (INITIALS)

## Topics