refc[adjoint]: Refactor PoleResidue derivative calculation #2585
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaugenst-flex
force-pushed
the
yaugenst-flex/refactor-poleresidue
branch
from
4033adc to
8c478c4
Compare
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
3 files reviewed, 2 comments
Edit PR Review Bot Settings | Greptile
Contributor
Diff CoverageDiff: origin/develop...HEAD, staged and unstaged changes
Summary
|
tylerflex
reviewed
Jun 18, 2025
tylerflex
approved these changes
Jun 19, 2025
Collaborator
tylerflex
left a comment
tylerflex
left a comment
There was a problem hiding this comment.
approved, thanks yannick!
yaugenst-flex
force-pushed
the
yaugenst-flex/refactor-poleresidue
branch
from
8c478c4 to
3ffca81
Compare
groberts-flex
approved these changes
Jun 23, 2025
Contributor
groberts-flex
left a comment
groberts-flex
left a comment
There was a problem hiding this comment.
great, I like this! like the simplification and re-use!
The derivative logic for both `PoleResidue` and the spatially-varying `CustomPoleResidue` has been refactored to use an analytical formula. This is achieved by: - Replacing the `autograd`-based implementations in both classes with the analytical formulas for the pole-residue model derivatives. - Creating a single, shared `staticmethod` (`_get_vjps_from_params`) in the base `PoleResidue` class to house this logic. - Updating the `_compute_derivatives` methods in both classes to be simple wrappers that call this new helper.
yaugenst-flex
force-pushed
the
yaugenst-flex/refactor-poleresidue
branch
from
3ffca81 to
a280a6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the "mysterious" factors in the adjoint gradient calculation for
CustomPoleResidueand refactors the derivative logic for bothPoleResidueandCustomPoleResidue. Tested on the gold nanoantenna notebook.The PR removes more code than it adds so you know it's good 😉
Greptile Summary
Refactors adjoint gradient calculations for PoleResidue models to use analytical derivatives instead of automatic differentiation, improving mathematical precision and code clarity.
tidy3d/components/medium.pyfor PoleResidue calculations_get_vjps_from_paramshelper method to consolidate derivative logic for both PoleResidue and CustomPoleResiduetests/test_autograd.pyto properly handle complex conjugates