-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Fluent Assertions 5 #33
Comments
I had a quick attempt at upgrading the code to FluentAssertions v5, but it look slike FA5 no longer supports .NET 4. This means the automatic NuGet upgrade fails as the MVC3 and MVC4 projects target .NET 4. I wasn't sure how best to proceed. |
@rikrak thanks for taking a look at this. I just had a look in one of our projects here, and it looks like MVC 5 only supports As this is going to be a breaking change, if you hit problems with the MVC 3 and 4 projects I wouldn't have a problem with dropping support for them now. |
Update: I'm new to Git/GitHub, so I'm not sure what I need to do next... :-) |
Great, all looks good and you're on the right track so far. Next up, can you open a pull request (more info here)? Once I've merged your changes in I'll ship a beta to nuget. |
OK, Pull request created. |
Fixed in #36. |
@rikrak any issues with the beta? If not I'll try to get a full version out next week. |
It's all good here. I've had it in our project for a week or so without issue. |
Thanks @rikrak. I just pushed 0.7.0. It should show up on nuget shortly. |
No description provided.
The text was updated successfully, but these errors were encountered: