Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Fluent Assertions 5 #33

Closed
kevinkuszyk opened this issue Oct 24, 2017 · 9 comments
Closed

Upgrade to Fluent Assertions 5 #33

kevinkuszyk opened this issue Oct 24, 2017 · 9 comments

Comments

@kevinkuszyk
Copy link
Member

No description provided.

@rikrak
Copy link
Contributor

rikrak commented Feb 13, 2018

I had a quick attempt at upgrading the code to FluentAssertions v5, but it look slike FA5 no longer supports .NET 4. This means the automatic NuGet upgrade fails as the MVC3 and MVC4 projects target .NET 4. I wasn't sure how best to proceed.
Can the MVC3 & 4 projects be simply upgraded to target .NET 4.5?

@kevinkuszyk
Copy link
Member Author

@rikrak thanks for taking a look at this.

I just had a look in one of our projects here, and it looks like MVC 5 only supports net45 and up, so yes feel free to go ahead an upgrade all the projects to that.

As this is going to be a breaking change, if you hit problems with the MVC 3 and 4 projects I wouldn't have a problem with dropping support for them now.

@rikrak
Copy link
Contributor

rikrak commented Feb 13, 2018

Update:
I've upgraded the MVC3 & MVC4 projects to .NET 4.5 and upgraded FA to v5.0.0. All the tests are passing :-)
I haven't, however tested any of this with a "real" project yet.
I've pushed my changes to my fork of this project on GitHub (branch: FA5_Upgrade).

I'm new to Git/GitHub, so I'm not sure what I need to do next... :-)

@kevinkuszyk
Copy link
Member Author

Great, all looks good and you're on the right track so far.

Next up, can you open a pull request (more info here)? Once I've merged your changes in I'll ship a beta to nuget.

@rikrak
Copy link
Contributor

rikrak commented Feb 13, 2018

OK, Pull request created.

@kevinkuszyk
Copy link
Member Author

Fixed in #36.

@kevinkuszyk
Copy link
Member Author

@rikrak any issues with the beta? If not I'll try to get a full version out next week.

@kevinkuszyk kevinkuszyk reopened this Mar 16, 2018
@rikrak
Copy link
Contributor

rikrak commented Mar 16, 2018

It's all good here. I've had it in our project for a week or so without issue.
For Ref: We're using v5.1.2 of FluentAssertions.

@kevinkuszyk
Copy link
Member Author

Thanks @rikrak. I just pushed 0.7.0. It should show up on nuget shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants