Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH/WIP] Adding first test to implement marching cubes #1000

Merged
merged 2 commits into from
Mar 23, 2025

Conversation

Leguark
Copy link
Member

@Leguark Leguark commented Mar 15, 2025

Description

Implementing marching cubes

Relates to

Checklist

  • My code uses type hinting for function and method arguments and return values.
  • I have created tests which cover my code.
  • The test code either 1. demonstrates at least one valuable use case (e.g. integration tests)
    or 2. verifies that outputs are as expected for given inputs (e.g. unit tests).
  • New tests pass locally with my changes.

Copy link
Member Author

Leguark commented Mar 15, 2025

Copy link
Member Author

Leguark commented Mar 15, 2025

To keep working in this PR you just need to checkout this branch and push the changes

Step I: Monolithic code extracting meshes

@javoha as far I understood you pretty much have this code. Just add it in the test so we can later extract the functions that we will need to put somewhere else and find out the data structures that we will need

Step II: Extracting functions and data classes and place them in the right location @Leguark

@Leguark Leguark changed the title [TEST/WIP] Adding first test to implement marching cubes [ENH/WIP] Adding first test to implement marching cubes Mar 16, 2025
@javoha
Copy link
Member

javoha commented Mar 17, 2025

Hi,
so I added the MC code to the test. It is probably more convoluted that it needds to be because I did a bunch of things to account for multiple elements in single structural groups (using the same scalar fields) and also some code to reorder to match the structural frame order.

Copy link
Member Author

Leguark commented Mar 18, 2025

great thanks. I will take a look at simplifying it as I extract code into functions and put it in the right location. I will try to come around this week.

@Leguark Leguark force-pushed the adding_marching_cubes branch from 07f6981 to 7cba374 Compare March 22, 2025 14:01
@Leguark Leguark marked this pull request as ready for review March 22, 2025 15:23
Copy link
Member Author

Leguark commented Mar 23, 2025

Merge activity

  • Mar 23, 4:11 AM EDT: A user started a stack merge that includes this pull request via Graphite.
  • Mar 23, 4:11 AM EDT: A user merged this pull request with Graphite.

@Leguark Leguark merged commit 3e4614e into main Mar 23, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants