Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no reflection in InstantTimeProvider, fixes #11975 #11977

Merged
merged 1 commit into from
Mar 26, 2025

Conversation

panchenko
Copy link
Contributor

Seems like there is not need to use reflection in InstantTimeProvider.
if Instant class is present, then we can use normally.

@kannanjgithub kannanjgithub added the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Mar 25, 2025
@grpc-kokoro grpc-kokoro removed the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Mar 25, 2025
@kannanjgithub kannanjgithub self-requested a review March 25, 2025 10:13
Copy link
Member

@ejona86 ejona86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this is probably the only way to get R8 to retain methods correctly.

@ejona86 ejona86 added kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run and removed kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run labels Mar 25, 2025
@kannanjgithub kannanjgithub merged commit 7507a9e into grpc:master Mar 26, 2025
16 checks passed
@kannanjgithub kannanjgithub added this to the 1.72 milestone Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants