Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(angular): add a landing page to go between lazy and standalone apps #30286

Merged
merged 1 commit into from
Mar 26, 2025

Conversation

brandyscarney
Copy link
Member

@brandyscarney brandyscarney commented Mar 20, 2025

What is the new behavior?

Adds a landing page to the Angular test app to make it easier to get to and debug standalone.

Does this introduce a breaking change?

  • Yes
  • No

Copy link

vercel bot commented Mar 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 20, 2025 8:24pm

@github-actions github-actions bot added the package: angular @ionic/angular package label Mar 20, 2025
@brandyscarney brandyscarney marked this pull request as ready for review March 20, 2025 20:35
@brandyscarney brandyscarney requested a review from a team as a code owner March 20, 2025 20:35
@brandyscarney brandyscarney requested review from ShaneK and thetaPC March 20, 2025 20:35
@brandyscarney brandyscarney enabled auto-merge March 25, 2025 16:10
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this deleted?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I had this set to merge on approval. This file was specific to the ng19 app but I updated the file in the base folder to match this file: https://github.com/ionic-team/ionic-framework/pull/30286/files#diff-174033d040c9d2279d515398002826936441e7892b50ecde6a815fb719c48b9e

Since they are the same now and what's in the base folder works for all versions, this isn't needed.

Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you so much for this! It's been annoying to test standalone. I also prefer the standalone landing page with the sections. Maybe we can do the same for lazy in the future.

@brandyscarney brandyscarney added this pull request to the merge queue Mar 26, 2025
Merged via the queue into main with commit 0893703 Mar 26, 2025
51 checks passed
@brandyscarney brandyscarney deleted the test/angular-standalone-test-app branch March 26, 2025 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: angular @ionic/angular package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants