Explicitly test auto conversion with DD version 3.42.0 (instead of the latest version)

Author: maarten-ic

docs/source/courses/advanced/imaspy_snippets/autoconvert_get.py

@@ -1,4 +1,5 @@
 import imaspy
+from imaspy.ids_defs import ASCII_BACKEND, IDS_TIME_MODE_HOMOGENEOUS
 from imaspy.util import get_data_dictionary_version
 
 # 1. Create test data
@@ -9,33 +10,31 @@
 pulse_schedule = factory.new("pulse_schedule")
 
 # Fill the IDS with some test data
-pulse_schedule.ids_properties.homogeneous_time = \
-    imaspy.ids_defs.IDS_TIME_MODE_HOMOGENEOUS
-pulse_schedule.ids_properties.comment = \
-    "Testing renamed IDS nodes with IMASPy"
-pulse_schedule.time = [1., 1.1, 1.2]
+pulse_schedule.ids_properties.homogeneous_time = IDS_TIME_MODE_HOMOGENEOUS
+pulse_schedule.ids_properties.comment = "Testing renamed IDS nodes with IMASPy"
+pulse_schedule.time = [1.0, 1.1, 1.2]
 
 pulse_schedule.ec.antenna.resize(1)
 antenna = pulse_schedule.ec.antenna[0]
 antenna.name = "ec.antenna[0].name in DD 3.25.0"
-antenna.launching_angle_pol.reference_name = \
+antenna.launching_angle_pol.reference_name = (
     "ec.antenna[0].launching_angle_pol.reference_name in DD 3.25.0"
+)
 antenna.launching_angle_pol.reference.data = [2.1, 2.2, 2.3]
-antenna.launching_angle_tor.reference_name = \
+antenna.launching_angle_tor.reference_name = (
     "ec.antenna[0].launching_angle_tor.reference_name in DD 3.25.0"
+)
 antenna.launching_angle_tor.reference.data = [3.1, 3.2, 3.3]
 antenna.phase.reference_name = "Phase reference name"
 
 # And store the IDS in a DBEntry using DD 3.25.0
-entry = imaspy.DBEntry(
-    imaspy.ids_defs.ASCII_BACKEND, "autoconvert", 1, 1, dd_version="3.25.0"
-)
+entry = imaspy.DBEntry(ASCII_BACKEND, "autoconvert", 1, 1, dd_version="3.25.0")
 entry.create()
 entry.put(pulse_schedule)
 entry.close()
 
-# 2. Reopen the DBEntry with a default DD version:
-entry = imaspy.DBEntry(imaspy.ids_defs.ASCII_BACKEND, "autoconvert", 1, 1)
+# 2. Reopen the DBEntry with DD 3.42.0:
+entry = imaspy.DBEntry(ASCII_BACKEND, "autoconvert", 1, 1, dd_version="3.42.0")
 entry.open()
 
 # 3. Get the pulse schedule IDS

imaspy/test/test_ids_convert.py

@@ -122,47 +122,43 @@ def test_dbentry_autoconvert1(backend, worker_id, tmp_path):
     if backend != MEMORY_BACKEND:
         entry_331.close()
 
-    entry_default = open_dbentry(backend, "r", worker_id, tmp_path)
-    default_version = entry_default.factory.version
-    assert default_version != "3.31.0"
+    entry_342 = open_dbentry(backend, "r", worker_id, tmp_path, dd_version="3.42.0")
 
     # Get without conversion
-    old_ids_get = entry_default.get("core_profiles", autoconvert=False)
+    old_ids_get = entry_342.get("core_profiles", autoconvert=False)
     assert old_ids_get.ids_properties.version_put.data_dictionary == "3.31.0"
     assert old_ids_get._dd_version == "3.31.0"
 
     # Work around ASCII backend bug...
     if backend == ASCII_BACKEND:
-        entry_default.close()
-        entry_default = open_dbentry(backend, "r", worker_id, tmp_path)
+        entry_342.close()
+        entry_342 = open_dbentry(backend, "r", worker_id, tmp_path)
 
     # Get with conversion
-    new_ids_get = entry_default.get("core_profiles")
+    new_ids_get = entry_342.get("core_profiles")
     assert new_ids_get.ids_properties.version_put.data_dictionary == "3.31.0"
-    assert new_ids_get._dd_version == default_version
+    assert new_ids_get._dd_version == "3.42.0"
 
-    entry_default.close()
+    entry_342.close()
 
 
 def test_dbentry_autoconvert2(backend, worker_id, tmp_path):
-    entry_default = open_dbentry(backend, "w", worker_id, tmp_path)
-    default_version = entry_default.factory.version
-    new_ids = entry_default.factory.new("core_profiles")
+    entry_342 = open_dbentry(backend, "w", worker_id, tmp_path, dd_version="3.42.0")
+    new_ids = entry_342.factory.new("core_profiles")
     new_ids.ids_properties.homogeneous_time = IDS_TIME_MODE_HETEROGENEOUS
 
     # Put without conversion:
-    entry_default.put(new_ids)
-    assert new_ids.ids_properties.version_put.data_dictionary == default_version
+    entry_342.put(new_ids)
+    assert new_ids.ids_properties.version_put.data_dictionary == "3.42.0"
     if backend != MEMORY_BACKEND:
-        entry_default.close()
+        entry_342.close()
 
     entry_331 = open_dbentry(backend, "r", worker_id, tmp_path, dd_version="3.31.0")
-    assert default_version != "3.31.0"
 
     # Get without conversion
     new_ids_get = entry_331.get("core_profiles", autoconvert=False)
-    assert new_ids_get.ids_properties.version_put.data_dictionary == default_version
-    assert new_ids_get._dd_version == default_version
+    assert new_ids_get.ids_properties.version_put.data_dictionary == "3.42.0"
+    assert new_ids_get._dd_version == "3.42.0"
 
     # Work around ASCII backend bug...
     if backend == ASCII_BACKEND:
@@ -171,7 +167,7 @@ def test_dbentry_autoconvert2(backend, worker_id, tmp_path):
 
     # Get with conversion
     old_ids_get = entry_331.get("core_profiles")
-    assert old_ids_get.ids_properties.version_put.data_dictionary == default_version
+    assert old_ids_get.ids_properties.version_put.data_dictionary == "3.42.0"
     assert old_ids_get._dd_version == "3.31.0"
 
     entry_331.close()