-
-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cut off less text in left-hand nav menu #823
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi berry120! 👋
Welcome, and thank you for opening your first PR in the repo!
Please wait for triaging by our maintainers.
Please take a look at our contributing guide.
@Haarolean this needs to be discussed with the designer |
yeah I believe we had a solution for long cluster names |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to our design, the sidebar width currently is 240px. The issue with long cluster names should be solved using this design approach rather than this hammer fix.
P.S. Please note that there has been another PR open on this matter (#727), I left the same comment there.
Further user feedback is requested. Please reply within 7 days or we might close the issue. |
@Haarolean Are you referring to this approach where the text is wrapped? If so then the wrapping looks much better to me (is this coming in the next release?) but even in this design it still looks like there's some wasted whitespace on the right hand side that could be used to avoid as much wrapping? |
Thanks for the additional feedback! We'll get back to your issue soon. |
What changes did you make?
Currently the maximum width of 110px in the left-hand menu is really conservative, dropping way more text than it needs:
160px seems like a much better choice:
Much more text is shown now, but it still cuts off appropriately before the drop-down icon.
Is there anything you'd like reviewers to focus on?
How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)
Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)
Check out Contributing and Code of Conduct
A picture of a cute animal (not mandatory but encouraged)