Skip to content

driver/power: Add support for tinycontrol tcPDU #1645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 4, 2025

Conversation

lsa-cs
Copy link
Contributor

@lsa-cs lsa-cs commented Apr 11, 2025

Description

This module adds a power driver for the tinycontrol tcPDU.

tcPDU is a network-enabled PDU: https://tinycontrol.pl/en/tcpdu/

Unfortunately, the existing 'tinycontrol'-driver cannot be reused because the API is quite different.
API-Documentation: https://docs.tinycontrol.pl/en/tcpdu/api/commands/

I have tested this code with real hardware with these versions:

  • HW: "v1.1"
  • SW: "1.28-tcpdu"

Checklist

  • Documentation for the feature
  • Tests for the feature
  • The arguments and description in doc/configuration.rst have been updated
  • PR has been tested

tcPDU is a network-enabled PDU by tinycontrol:
https://tinycontrol.pl/en/tcpdu/

This commit adds support and documentation for it.

Unfortunately, the existing 'tinycontrol'-driver cannot be reused
because the API is quite different.

Signed-off-by: Leon Sakkas <leon.sakkas@corscience.com>
Copy link

codecov bot commented Jul 4, 2025

Codecov Report

Attention: Patch coverage is 26.66667% with 11 lines in your changes missing coverage. Please review.

Project coverage is 55.7%. Comparing base (728dd38) to head (8bee780).
Report is 2 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
labgrid/driver/power/tinycontrol_tcpdu.py 26.6% 11 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master   #1645     +/-   ##
========================================
- Coverage    55.7%   55.7%   -0.1%     
========================================
  Files         170     171      +1     
  Lines       13393   13408     +15     
========================================
+ Hits         7473    7477      +4     
- Misses       5920    5931     +11     
Flag Coverage Δ
3.10 55.7% <26.6%> (-0.1%) ⬇️
3.11 55.7% <26.6%> (-0.1%) ⬇️
3.12 55.7% <26.6%> (-0.1%) ⬇️
3.13 55.7% <26.6%> (-0.1%) ⬇️
3.9 55.7% <26.6%> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Bastian-Krause Bastian-Krause left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. The power backend looks good.

Since this adds support for another network PDU, see our merge policy for those: #1031. I'm gonna merge this into labgrid, but maybe it makes sense in the long run to add support for it into pdudaemon and use that.

@Bastian-Krause Bastian-Krause merged commit f9d8ca0 into labgrid-project:master Jul 4, 2025
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants