[NFC][X86][ISel] Remove the unused assert

[shining1984]

The condition of assert is always true, so just remove it.
OptForMinSize means hasMinSize(), which is hasFnAttribute(Attribute::MinSize).
hasOptSize() is hasFnAttribute(Attribute::OptimizeForSize) || hasMinSize().
So, '!hasMinSize() || hasFnAttribute(Attribute::OptimizeForSize) || hasMinSize()' is awalys true.

---

llvm/include/llvm/IR/Function.h

/// Optimize this function for minimum size (-Oz).
  bool hasMinSize() const { return hasFnAttribute(Attribute::MinSize); }

  /// Optimize this function for size (-Os) or minimum size (-Oz).
  bool hasOptSize() const {
    return hasFnAttribute(Attribute::OptimizeForSize) || hasMinSize();
  }

[llvmbot]

@llvm/pr-subscribers-backend-x86

Author: Ningning Shi(史宁宁) (shining1984)

Changes

The condition of assert is always true, so just remove it.
OptForMinSize means hasMinSize(), which is hasFnAttribute(Attribute::MinSize).
hasOptSize() is hasFnAttribute(Attribute::OptimizeForSize) || hasMinSize().
So, '!hasMinSize() || hasFnAttribute(Attribute::OptimizeForSize) || hasMinSize()' is awalys true.

---

llvm/include/llvm/IR/Function.h
` /// Optimize this function for minimum size (-Oz).
bool hasMinSize() const { return hasFnAttribute(Attribute::MinSize); }

/// Optimize this function for size (-Os) or minimum size (-Oz).
bool hasOptSize() const {
return hasFnAttribute(Attribute::OptimizeForSize) || hasMinSize();
}`

---

Full diff: https://github.com/llvm/llvm-project/pull/133029.diff

1 Files Affected:

• (modified) llvm/lib/Target/X86/X86ISelDAGToDAG.cpp (-2)

diff --git a/llvm/lib/Target/X86/X86ISelDAGToDAG.cpp b/llvm/lib/Target/X86/X86ISelDAGToDAG.cpp
index 878c054503473..d322e70fc0c20 100644
--- a/llvm/lib/Target/X86/X86ISelDAGToDAG.cpp
+++ b/llvm/lib/Target/X86/X86ISelDAGToDAG.cpp
@@ -184,8 +184,6 @@ namespace {
 
       // OptFor[Min]Size are used in pattern predicates that isel is matching.
       OptForMinSize = MF.getFunction().hasMinSize();
-      assert((!OptForMinSize || MF.getFunction().hasOptSize()) &&
-             "OptForMinSize implies OptForSize");
       return SelectionDAGISel::runOnMachineFunction(MF);
     }
 

[wangpc-pp]

LGTM. Good catch!