Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[asan][NFCI] Add ASAN_POISONING_H header guard #133178

Merged
merged 1 commit into from
Mar 27, 2025

Conversation

thurstond
Copy link
Contributor

No description provided.

@llvmbot
Copy link
Member

llvmbot commented Mar 26, 2025

@llvm/pr-subscribers-compiler-rt-sanitizer

Author: Thurston Dang (thurstond)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/133178.diff

1 Files Affected:

  • (modified) compiler-rt/lib/asan/asan_poisoning.h (+5)
diff --git a/compiler-rt/lib/asan/asan_poisoning.h b/compiler-rt/lib/asan/asan_poisoning.h
index 600bd011f304c..b68af1086e17d 100644
--- a/compiler-rt/lib/asan/asan_poisoning.h
+++ b/compiler-rt/lib/asan/asan_poisoning.h
@@ -11,6 +11,9 @@
 // Shadow memory poisoning by ASan RTL and by user application.
 //===----------------------------------------------------------------------===//
 
+#ifndef ASAN_POISONING_H
+#define ASAN_POISONING_H
+
 #include "asan_interceptors.h"
 #include "asan_internal.h"
 #include "asan_mapping.h"
@@ -96,3 +99,5 @@ ALWAYS_INLINE void FastPoisonShadowPartialRightRedzone(
 void FlushUnneededASanShadowMemory(uptr p, uptr size);
 
 }  // namespace __asan
+
+#endif  // ASAN_POISONING_H

@vitalybuka vitalybuka merged commit 68e90e4 into llvm:main Mar 27, 2025
14 checks passed
@llvm-ci
Copy link
Collaborator

llvm-ci commented Mar 27, 2025

LLVM Buildbot has detected a new failure on builder clang-aarch64-sve-vls running on linaro-g3-03 while building compiler-rt at step 7 "ninja check 1".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/143/builds/6487

Here is the relevant piece of the build log for the reference
Step 7 (ninja check 1) failure: stage 1 checked (failure)
...
llvm-lit: /home/tcwg-buildbot/worker/clang-aarch64-sve-vls/llvm/llvm/utils/lit/lit/llvm/config.py:520: note: using ld64.lld: /home/tcwg-buildbot/worker/clang-aarch64-sve-vls/stage1/bin/ld64.lld
llvm-lit: /home/tcwg-buildbot/worker/clang-aarch64-sve-vls/llvm/llvm/utils/lit/lit/llvm/config.py:520: note: using wasm-ld: /home/tcwg-buildbot/worker/clang-aarch64-sve-vls/stage1/bin/wasm-ld
llvm-lit: /home/tcwg-buildbot/worker/clang-aarch64-sve-vls/llvm/llvm/utils/lit/lit/discovery.py:276: warning: input '/home/tcwg-buildbot/worker/clang-aarch64-sve-vls/stage1/runtimes/runtimes-bins/compiler-rt/test/interception/Unit' contained no tests
llvm-lit: /home/tcwg-buildbot/worker/clang-aarch64-sve-vls/llvm/llvm/utils/lit/lit/discovery.py:276: warning: input '/home/tcwg-buildbot/worker/clang-aarch64-sve-vls/stage1/runtimes/runtimes-bins/compiler-rt/test/sanitizer_common/Unit' contained no tests
llvm-lit: /home/tcwg-buildbot/worker/clang-aarch64-sve-vls/llvm/llvm/utils/lit/lit/llvm/config.py:520: note: using ld.lld: /home/tcwg-buildbot/worker/clang-aarch64-sve-vls/stage1/bin/ld.lld
llvm-lit: /home/tcwg-buildbot/worker/clang-aarch64-sve-vls/llvm/llvm/utils/lit/lit/llvm/config.py:520: note: using lld-link: /home/tcwg-buildbot/worker/clang-aarch64-sve-vls/stage1/bin/lld-link
llvm-lit: /home/tcwg-buildbot/worker/clang-aarch64-sve-vls/llvm/llvm/utils/lit/lit/llvm/config.py:520: note: using ld64.lld: /home/tcwg-buildbot/worker/clang-aarch64-sve-vls/stage1/bin/ld64.lld
llvm-lit: /home/tcwg-buildbot/worker/clang-aarch64-sve-vls/llvm/llvm/utils/lit/lit/llvm/config.py:520: note: using wasm-ld: /home/tcwg-buildbot/worker/clang-aarch64-sve-vls/stage1/bin/wasm-ld
-- Testing: 97383 tests, 64 workers --
UNRESOLVED: Flang :: Driver/slp-vectorize.ll (1 of 97383)
******************** TEST 'Flang :: Driver/slp-vectorize.ll' FAILED ********************
Test has no 'RUN:' line
********************
PASS: MLIR :: Integration/Dialect/SparseTensor/CPU/sparse_matmul.mlir (2 of 97383)
PASS: MLIR :: Integration/Dialect/SparseTensor/CPU/sparse_conversion.mlir (3 of 97383)
PASS: UBSan-ThreadSanitizer-aarch64 :: TestCases/Integer/shift.cpp (4 of 97383)
PASS: MLIR :: Integration/Dialect/SparseTensor/CPU/sparse_binary.mlir (5 of 97383)
PASS: LLVM :: CodeGen/RISCV/rvv/expandload.ll (6 of 97383)
PASS: libFuzzer-aarch64-default-Linux :: msan.test (7 of 97383)
PASS: Clangd :: protocol.test (8 of 97383)
PASS: Clang :: CodeGen/X86/avx512f-builtins.c (9 of 97383)
PASS: Clang :: CodeGenCXX/dllimport-members.cpp (10 of 97383)
PASS: UBSan-ThreadSanitizer-aarch64 :: TestCases/ImplicitConversion/signed-integer-truncation-or-sign-change-ignorelist.c (11 of 97383)
PASS: LLVM :: tools/llvm-reduce/reduce-distinct-metadata.ll (12 of 97383)
PASS: LLVM :: CodeGen/AMDGPU/llvm.amdgcn.permlane.ll (13 of 97383)
PASS: UBSan-MemorySanitizer-aarch64 :: TestCases/ImplicitConversion/signed-integer-truncation-ignorelist.c (14 of 97383)
PASS: UBSan-AddressSanitizer-aarch64 :: TestCases/ImplicitConversion/signed-integer-truncation-ignorelist.c (15 of 97383)
PASS: AddressSanitizer-Unit :: ./Asan-aarch64-calls-Noinst-Test/12/16 (16 of 97383)
PASS: UBSan-MemorySanitizer-aarch64 :: TestCases/ImplicitConversion/unsigned-integer-truncation-ignorelist.c (17 of 97383)
PASS: AddressSanitizer-Unit :: ./Asan-aarch64-inline-Noinst-Test/12/16 (18 of 97383)
PASS: Clang :: OpenMP/target_simd_codegen_registration.cpp (19 of 97383)
PASS: libFuzzer-aarch64-default-Linux :: value-profile-cmp.test (20 of 97383)
PASS: Clang :: CodeGen/X86/rot-intrinsics.c (21 of 97383)
PASS: Clang :: Analysis/runtime-regression.c (22 of 97383)
PASS: Clang :: CodeGen/X86/sse2-builtins.c (23 of 97383)
PASS: HWAddressSanitizer-aarch64 :: TestCases/Linux/create-thread-stress.cpp (24 of 97383)
PASS: Clang :: CodeGen/X86/avx-builtins.c (25 of 97383)
PASS: ThreadSanitizer-aarch64 :: deadlock_detector_stress_test.cpp (26 of 97383)
PASS: SanitizerCommon-hwasan-aarch64-Linux :: Linux/signal_segv_handler.cpp (27 of 97383)
PASS: SanitizerCommon-asan-aarch64-Linux :: Linux/signal_segv_handler.cpp (28 of 97383)
PASS: SanitizerCommon-tsan-aarch64-Linux :: Linux/signal_segv_handler.cpp (29 of 97383)
PASS: Clang :: OpenMP/target_teams_distribute_parallel_for_simd_codegen_registration.cpp (30 of 97383)
PASS: LLVM :: CodeGen/AMDGPU/sched-group-barrier-pipeline-solver.mir (31 of 97383)
PASS: SanitizerCommon-ubsan-aarch64-Linux :: Linux/signal_segv_handler.cpp (32 of 97383)
PASS: SanitizerCommon-lsan-aarch64-Linux :: Linux/signal_segv_handler.cpp (33 of 97383)
PASS: SanitizerCommon-msan-aarch64-Linux :: Linux/signal_segv_handler.cpp (34 of 97383)
PASS: LLVM :: CodeGen/RISCV/attributes.ll (35 of 97383)
PASS: Clang :: Preprocessor/predefined-arch-macros.c (36 of 97383)
PASS: Clang :: Analysis/a_flaky_crash.cpp (37 of 97383)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants