-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
llvm-reduce: Fix losing callsite attributes when removing arguments #133407
Merged
arsenm
merged 1 commit into
main
from
users/arsenm/llvm-reduce/fix-losing-attributes-when-removing-arguments
Mar 28, 2025
Merged
llvm-reduce: Fix losing callsite attributes when removing arguments #133407
arsenm
merged 1 commit into
main
from
users/arsenm/llvm-reduce/fix-losing-attributes-when-removing-arguments
Mar 28, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 28, 2025
This was referenced Mar 28, 2025
shiltian
approved these changes
Mar 28, 2025
Merge activity
|
8afdd1b
to
0d5c6be
Compare
Base automatically changed from
users/arsenm/llvm-reduce/avoid-invalid-reduction-x86_intrcc
to
main
March 28, 2025 16:11
52eb2ed
to
3c5403e
Compare
The attribute APIs make this cumbersome. There seem to be missing overloads using AttrBuilder for the function attrs. Plus there doesn't seem to be a direct way to set the function attrs on the call.
3c5403e
to
b36fb74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The attribute APIs make this cumbersome. There seem to be missing
overloads using AttrBuilder for the function attrs. Plus there doesn't
seem to be a direct way to set the function attrs on the call.