Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

llvm-reduce: Fix losing callsite attributes when removing arguments #133407

Conversation

arsenm
Copy link
Contributor

@arsenm arsenm commented Mar 28, 2025

The attribute APIs make this cumbersome. There seem to be missing
overloads using AttrBuilder for the function attrs. Plus there doesn't
seem to be a direct way to set the function attrs on the call.

Copy link
Contributor Author

arsenm commented Mar 28, 2025

Merge activity

  • Mar 28, 12:07 PM EDT: A user started a stack merge that includes this pull request via Graphite.
  • Mar 28, 12:12 PM EDT: Graphite rebased this pull request as part of a merge.
  • Mar 28, 12:15 PM EDT: Graphite rebased this pull request as part of a merge.
  • Mar 28, 12:18 PM EDT: Graphite rebased this pull request as part of a merge.
  • Mar 28, 12:20 PM EDT: A user merged this pull request with Graphite.

@arsenm arsenm force-pushed the users/arsenm/llvm-reduce/avoid-invalid-reduction-x86_intrcc branch from 8afdd1b to 0d5c6be Compare March 28, 2025 16:08
Base automatically changed from users/arsenm/llvm-reduce/avoid-invalid-reduction-x86_intrcc to main March 28, 2025 16:11
@arsenm arsenm force-pushed the users/arsenm/llvm-reduce/fix-losing-attributes-when-removing-arguments branch 2 times, most recently from 52eb2ed to 3c5403e Compare March 28, 2025 16:14
The attribute APIs make this cumbersome. There seem to be missing
overloads using AttrBuilder for the function attrs. Plus there doesn't
seem to be a direct way to set the function attrs on the call.
@arsenm arsenm force-pushed the users/arsenm/llvm-reduce/fix-losing-attributes-when-removing-arguments branch from 3c5403e to b36fb74 Compare March 28, 2025 16:17
@arsenm arsenm merged commit 1b86867 into main Mar 28, 2025
6 of 10 checks passed
@arsenm arsenm deleted the users/arsenm/llvm-reduce/fix-losing-attributes-when-removing-arguments branch March 28, 2025 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants