Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libc++] Remove _LIBCPP_EXTERN_TEMPLATE_TYPE_VIS and _LIBCPP_CLASS_TEMPLATE_INSTANTIATION_VIS #133704

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

philnik777
Copy link
Contributor

No description provided.

@philnik777 philnik777 force-pushed the simplify_visibility_annotations branch from 421ce12 to a8b1253 Compare March 31, 2025 11:28
Copy link

⚠️ C/C++ code formatter, clang-format found issues in your code. ⚠️

You can test this locally with the following command:
git-clang-format --diff HEAD~1 HEAD --extensions ,cpp,h -- libcxx/include/__config libcxx/include/__locale libcxx/include/__ostream/basic_ostream.h libcxx/include/fstream libcxx/include/ios libcxx/include/istream libcxx/include/locale libcxx/include/sstream libcxx/include/streambuf libcxx/src/ios.instantiations.cpp libcxx/src/locale.cpp
View the diff from clang-format here.
diff --git a/libcxx/include/__config b/libcxx/include/__config
index be96aaac5..066798adb 100644
--- a/libcxx/include/__config
+++ b/libcxx/include/__config
@@ -541,8 +541,8 @@ typedef __char32_t char32_t;
 #  endif
 
 #  if __has_warning("-Wdllexport-explicit-instantiation")
-#      define _LIBCPP_CLANG_DIAGNOSTIC_IGNORE_DLLEXPORT                                                                \
-        _LIBCPP_CLANG_DIAGNOSTIC_IGNORED("-Wdllexport-explicit-instantiation")
+#    define _LIBCPP_CLANG_DIAGNOSTIC_IGNORE_DLLEXPORT                                                                  \
+      _LIBCPP_CLANG_DIAGNOSTIC_IGNORED("-Wdllexport-explicit-instantiation")
 #  elif defined(_LIBCPP_OBJECT_FORMAT_COFF)
 #    define _LIBCPP_CLANG_DIAGNOSTIC_IGNORE_DLLEXPORT                                                                  \
       _LIBCPP_CLANG_DIAGNOSTIC_IGNORED("-Wignored-attributes")                                                         \
diff --git a/libcxx/src/locale.cpp b/libcxx/src/locale.cpp
index 88430119f..b6f10ca4c 100644
--- a/libcxx/src/locale.cpp
+++ b/libcxx/src/locale.cpp
@@ -5716,12 +5716,9 @@ template class _LIBCPP_EXPORTED_FROM_ABI messages_byname<char>;
 _LIBCPP_IF_WIDE_CHARACTERS(template class _LIBCPP_EXPORTED_FROM_ABI messages_byname<wchar_t>;)
 
 template class _LIBCPP_EXPORTED_FROM_ABI codecvt_byname<char, char, mbstate_t>;
-_LIBCPP_IF_WIDE_CHARACTERS(
-    template class _LIBCPP_EXPORTED_FROM_ABI codecvt_byname<wchar_t, char, mbstate_t>;)
-template class _LIBCPP_DEPRECATED_IN_CXX20 _LIBCPP_EXPORTED_FROM_ABI
-    codecvt_byname<char16_t, char, mbstate_t>;
-template class _LIBCPP_DEPRECATED_IN_CXX20 _LIBCPP_EXPORTED_FROM_ABI
-    codecvt_byname<char32_t, char, mbstate_t>;
+_LIBCPP_IF_WIDE_CHARACTERS(template class _LIBCPP_EXPORTED_FROM_ABI codecvt_byname<wchar_t, char, mbstate_t>;)
+template class _LIBCPP_DEPRECATED_IN_CXX20 _LIBCPP_EXPORTED_FROM_ABI codecvt_byname<char16_t, char, mbstate_t>;
+template class _LIBCPP_DEPRECATED_IN_CXX20 _LIBCPP_EXPORTED_FROM_ABI codecvt_byname<char32_t, char, mbstate_t>;
 #if _LIBCPP_HAS_CHAR8_T
 template class _LIBCPP_EXPORTED_FROM_ABI codecvt_byname<char16_t, char8_t, mbstate_t>;
 template class _LIBCPP_EXPORTED_FROM_ABI codecvt_byname<char32_t, char8_t, mbstate_t>;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant